Skip to content

Refactor arcade embeds #11722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Refactor arcade embeds #11722

merged 4 commits into from
Nov 7, 2024

Conversation

a-hariti
Copy link
Collaborator

@a-hariti a-hariti commented Nov 4, 2024

Closes #11714

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 4:58pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 4:58pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 4:58pm

Copy link

codecov bot commented Nov 4, 2024

Bundle Report

Changes will increase total bundle size by 459 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.58MB 465 bytes (0.01%) ⬆️
sentry-docs-client-array-push 8.94MB 6 bytes (-0.0%) ⬇️

@a-hariti a-hariti changed the title remove irrelevant title attributes from arcade embeds refactor arcade embeds Nov 4, 2024
@a-hariti a-hariti changed the title refactor arcade embeds Refactor arcade embeds Nov 4, 2024
Copy link
Contributor

@stephanie-anderson stephanie-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! Thank you! :) Please also add a little section in the contribution guides 🙏

@a-hariti
Copy link
Collaborator Author

a-hariti commented Nov 7, 2024

I did @stephanie-anderson

there's one weird 404 error preventing us from merging this PR

@a-hariti a-hariti merged commit 8c70960 into master Nov 7, 2024
12 of 13 checks passed
@a-hariti a-hariti deleted the fix-arcade-titles branch November 7, 2024 13:06
martinhaintz pushed a commit that referenced this pull request Nov 11, 2024
* master: (39 commits)
  getsentry/relay@403f2bf
  feat(native): add backend trade-offs to Advanced Usage (#11721)
  🔧 chore(api): add additional troubleshooting instructions to publish api docs (#11772)
  Bump API schema to 02adb960 (#11773)
  Update metric-alert-config.mdx (#11760)
  update w-9 tax form (#11764)
  chore: silence fetch cache error due to size limit (#11767)
  fix Ureal engine DSN placeholder (#11769)
  feat: Banner pathname regex (#11761)
  docs(nuxt): Add troubleshoot pnpm (#11720)
  Docker Desktop to Colima fix (#11752)
  Bump API schema to d51784a6 (#11759)
  ref(feedback): update user feedback docs to include external issue linking & auto issue creation (#11729)
  getsentry/relay@d23c39a
  Changed /store to /envelope (because /store does not exist anymore (#11755)
  Refactor arcade embeds (#11722)
  feat(js): Add `skipBrowserExtensionCheck` documentation (#11693)
  getsentry/relay@a7d9096
  fix mermaid charts in dark mode (#11754)
  fix: Log4j configurations and wording (#11395)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate titles on Arcade embeds
2 participants