Add sample rate to SDK docs. #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcramer
approved these changes
Mar 10, 2017
LewisJEllis
reviewed
Mar 10, 2017
docs/clientdev/overview.rst
Outdated
|
|
||
| .. sourcecode:: python | ||
|
|
||
| sample_rate = options.get('sample_rate') or 1.0 |
There was a problem hiding this comment.
if options.get('sample_rate') returns 0 this expression will evaluate to 1.0 instead, i think theres a legitimate case for setting sample_rate to 0?
There was a problem hiding this comment.
Welp, you're the CEO now.
docs/clientdev/overview.rst
Outdated
|
|
||
| sample_rate = options.get('sample_rate') or 1.0 | ||
|
|
||
| # assuming random() returns a value between 0.0 and 1.0 |
There was a problem hiding this comment.
maybe clarify 0 inclusive 1.0 exclusive, details might technically matter as ted pointed out in getsentry/raven-python#978
There was a problem hiding this comment.
Good call, will do.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is short and sweet, I didn't know what else to say.