Tag all spans with thread info #3101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3101 +/- ##
=======================================
Coverage 87.66% 87.66%
=======================================
Files 288 290 +2
Lines 9822 9834 +12
=======================================
+ Hits 8610 8621 +11
- Misses 1212 1213 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 73dca78 | 476.53 ms | 522.21 ms | 45.68 ms |
| 93b7728 | 475.28 ms | 489.13 ms | 13.86 ms |
| 0fb45d0 | 482.79 ms | 554.02 ms | 71.23 ms |
| e2d675d | 457.92 ms | 529.17 ms | 71.25 ms |
| 79f6b41 | 469.66 ms | 525.90 ms | 56.24 ms |
| 81f83eb | 471.40 ms | 522.14 ms | 50.74 ms |
| ec78888 | 457.94 ms | 519.96 ms | 62.02 ms |
| 3615e19 | 468.38 ms | 504.71 ms | 36.33 ms |
| 4481076 | 484.08 ms | 505.70 ms | 21.61 ms |
| 793f4dc | 462.68 ms | 544.21 ms | 81.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 73dca78 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 93b7728 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 0fb45d0 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| e2d675d | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 79f6b41 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 81f83eb | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| ec78888 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 3615e19 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| 4481076 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 793f4dc | 6.54 MiB | 7.69 MiB | 1.15 MiB |
buenaflor
requested changes
Jul 22, 2025
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93b7728 | 1247.23 ms | 1264.87 ms | 17.64 ms |
| 3615e19 | 1225.02 ms | 1234.57 ms | 9.55 ms |
| 79f6b41 | 1269.33 ms | 1279.71 ms | 10.38 ms |
| cc4e375 | 1253.06 ms | 1263.81 ms | 10.75 ms |
| b6c8720 | 1252.65 ms | 1266.61 ms | 13.96 ms |
| 575ebaa | 1262.20 ms | 1274.24 ms | 12.04 ms |
| ec78888 | 1251.37 ms | 1269.40 ms | 18.04 ms |
| 793f4dc | 1262.50 ms | 1282.35 ms | 19.85 ms |
| 765aa8b | 1259.09 ms | 1269.90 ms | 10.82 ms |
| 2d34233 | 1258.19 ms | 1268.92 ms | 10.73 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93b7728 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 3615e19 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 79f6b41 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| cc4e375 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| b6c8720 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 575ebaa | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| ec78888 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 793f4dc | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 765aa8b | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 2d34233 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
…/sentry-dart into enha/add-isolate-info-to-spans
buenaflor
reviewed
Jul 29, 2025
Contributor
buenaflor
left a comment
buenaflor
left a comment
There was a problem hiding this comment.
nice 👍
tbh I don't like it so much that we are using the options for storing everything but I guess it's a convention now in this codebase
Collaborator
Author
|
@buenaflor We could start to move internal classes out of options and into something like a dependency container or similar. |
Contributor
we can come up with something later but it's fine for now |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Tag all spans with thread info
OnSpanStartlifecycle event for tracer span creation💡 Motivation and Context
Closes #2505
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps