Skip to content

Add module in SentryStackFrame #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented May 12, 2025

📜 Description

For package frames, the module gets now reported. This allows users to use the stack.module filter in the Sentry search.

💡 Motivation and Context

#2929

💚 How did you test it?

  • New tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.65%. Comparing base (bc3ad3c) to head (5e99354).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2931      +/-   ##
==========================================
+ Coverage   87.63%   87.65%   +0.02%     
==========================================
  Files         272      272              
  Lines        9047     9051       +4     
==========================================
+ Hits         7928     7934       +6     
+ Misses       1119     1117       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ueman
Copy link
Collaborator Author

ueman commented May 13, 2025

The current failures seem to be due to the CI setup. The integration test complains about a missing auth token, I suppose that's due to me being an outside contributor, and the non-integration test failure is due to 429 too many request flake.

@ueman ueman marked this pull request as ready for review May 13, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant