Skip to content

Sentry Structured Logs #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Sentry Structured Logs #2919

wants to merge 3 commits into from

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented May 7, 2025

📜 Description

💡 Motivation and Context

Closes #2915

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented May 7, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Sentry Structured Logs ([#2919](https://github.com/getsentry/sentry-dart/pull/2919))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 2b265e7

Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 97.67442% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.72%. Comparing base (bc3ad3c) to head (2b265e7).

Files with missing lines Patch % Lines
dart/lib/src/noop_log_batcher.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2919      +/-   ##
==========================================
+ Coverage   87.63%   87.72%   +0.09%     
==========================================
  Files         272      277       +5     
  Lines        9047     9133      +86     
==========================================
+ Hits         7928     8012      +84     
- Misses       1119     1121       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented May 7, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1252.19 ms 1268.96 ms 16.77 ms
Size 8.43 MiB 10.02 MiB 1.58 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5e8d2b3 1255.71 ms 1267.98 ms 12.27 ms
051e97a 1245.94 ms 1249.51 ms 3.57 ms
07cd9e8 1237.04 ms 1257.50 ms 20.46 ms
7fd33d3 1241.92 ms 1265.47 ms 23.55 ms
a24a1db 1257.71 ms 1271.57 ms 13.87 ms
5aa047a 1236.57 ms 1241.02 ms 4.45 ms
abfcdb5 1230.87 ms 1244.94 ms 14.06 ms
7659cbe 1246.70 ms 1265.88 ms 19.17 ms
4d046e0 1243.08 ms 1255.98 ms 12.90 ms
bd1b990 1209.43 ms 1226.96 ms 17.53 ms

App size

Revision Plain With Sentry Diff
5e8d2b3 8.29 MiB 9.36 MiB 1.07 MiB
051e97a 8.28 MiB 9.34 MiB 1.06 MiB
07cd9e8 8.38 MiB 9.77 MiB 1.40 MiB
7fd33d3 8.38 MiB 9.78 MiB 1.40 MiB
a24a1db 8.42 MiB 9.91 MiB 1.49 MiB
5aa047a 8.29 MiB 9.39 MiB 1.10 MiB
abfcdb5 8.33 MiB 9.64 MiB 1.31 MiB
7659cbe 8.42 MiB 9.89 MiB 1.47 MiB
4d046e0 8.42 MiB 9.83 MiB 1.40 MiB
bd1b990 8.32 MiB 9.38 MiB 1.06 MiB

@denrase denrase mentioned this pull request May 8, 2025
6 tasks
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 454.83 ms 537.04 ms 82.21 ms
Size 6.44 MiB 7.43 MiB 1011.23 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f7f46dc 306.38 ms 363.32 ms 56.95 ms
b56b25c 438.09 ms 563.34 ms 125.25 ms
a775d3f 359.58 ms 436.68 ms 77.10 ms
c70e01a 331.04 ms 401.46 ms 70.42 ms
84c28cd 415.11 ms 549.44 ms 134.33 ms
547db82 453.40 ms 482.88 ms 29.48 ms
ca9f398 476.88 ms 518.38 ms 41.50 ms
21d4150 379.31 ms 449.23 ms 69.93 ms
d1488a1 516.78 ms 585.04 ms 68.27 ms
b39b48c 474.21 ms 529.62 ms 55.41 ms

App size

Revision Plain With Sentry Diff
f7f46dc 6.06 MiB 7.03 MiB 993.54 KiB
b56b25c 6.46 MiB 7.48 MiB 1.02 MiB
a775d3f 6.27 MiB 7.20 MiB 957.75 KiB
c70e01a 5.94 MiB 6.97 MiB 1.03 MiB
84c28cd 6.49 MiB 7.56 MiB 1.07 MiB
547db82 6.49 MiB 7.56 MiB 1.07 MiB
ca9f398 6.49 MiB 7.56 MiB 1.07 MiB
21d4150 5.94 MiB 6.97 MiB 1.03 MiB
d1488a1 6.46 MiB 7.48 MiB 1.03 MiB
b39b48c 6.46 MiB 7.48 MiB 1.02 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry Structured Logs for Dart/Flutter
1 participant