-
-
Notifications
You must be signed in to change notification settings - Fork 277
feat: spotlight support #1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: spotlight support #1786
Conversation
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1786 +/- ##
==========================================
+ Coverage 88.54% 88.57% +0.02%
==========================================
Files 202 206 +4
Lines 6800 6834 +34
==========================================
+ Hits 6021 6053 +32
- Misses 779 781 +2 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d883d62 | 330.15 ms | 378.48 ms | 48.33 ms |
| 8d64376 | 302.88 ms | 356.84 ms | 53.96 ms |
| 9d43f71 | 318.06 ms | 370.38 ms | 52.32 ms |
| ddc97ad | 331.45 ms | 384.06 ms | 52.61 ms |
| a1a1545 | 295.21 ms | 351.16 ms | 55.95 ms |
| 48adddf | 353.96 ms | 431.10 ms | 77.14 ms |
| 64af39c | 386.80 ms | 471.11 ms | 84.31 ms |
| a61674e | 331.35 ms | 391.06 ms | 59.71 ms |
| ad69abc | 297.35 ms | 385.89 ms | 88.54 ms |
| 8609bd8 | 359.76 ms | 437.40 ms | 77.64 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d883d62 | 6.15 MiB | 7.13 MiB | 999.97 KiB |
| 8d64376 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| 9d43f71 | 6.16 MiB | 7.14 MiB | 1011.26 KiB |
| ddc97ad | 6.16 MiB | 7.14 MiB | 1003.75 KiB |
| a1a1545 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| 48adddf | 6.27 MiB | 7.20 MiB | 959.09 KiB |
| 64af39c | 6.27 MiB | 7.20 MiB | 958.83 KiB |
| a61674e | 6.06 MiB | 7.03 MiB | 990.29 KiB |
| ad69abc | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| 8609bd8 | 6.27 MiB | 7.20 MiB | 959.07 KiB |
Previous results on branch: feat/spotlight
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3a985bd | 401.90 ms | 463.67 ms | 61.77 ms |
| 4ee46f7 | 389.17 ms | 411.63 ms | 22.47 ms |
| 00dba0d | 383.36 ms | 456.00 ms | 72.64 ms |
| b93288a | 386.93 ms | 420.87 ms | 33.94 ms |
| 52e500e | 378.42 ms | 444.10 ms | 65.68 ms |
| 574550e | 365.08 ms | 427.06 ms | 61.98 ms |
| 6784f06 | 364.56 ms | 432.13 ms | 67.57 ms |
| e864406 | 362.63 ms | 428.86 ms | 66.23 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3a985bd | 6.33 MiB | 7.26 MiB | 943.78 KiB |
| 4ee46f7 | 6.33 MiB | 7.26 MiB | 946.25 KiB |
| 00dba0d | 6.33 MiB | 7.26 MiB | 944.47 KiB |
| b93288a | 6.33 MiB | 7.26 MiB | 944.52 KiB |
| 52e500e | 6.33 MiB | 7.26 MiB | 944.47 KiB |
| 574550e | 6.33 MiB | 7.26 MiB | 944.47 KiB |
| 6784f06 | 6.33 MiB | 7.26 MiB | 946.25 KiB |
| e864406 | 6.33 MiB | 7.26 MiB | 947.23 KiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8fa3934 | 1252.79 ms | 1272.41 ms | 19.62 ms |
| 4ad2751 | 1247.67 ms | 1249.20 ms | 1.53 ms |
| 5112c69 | 1272.76 ms | 1293.37 ms | 20.61 ms |
| ef31c7f | 1272.43 ms | 1295.71 ms | 23.29 ms |
| a61674e | 1275.51 ms | 1290.81 ms | 15.30 ms |
| cd16818 | 1254.78 ms | 1267.76 ms | 12.98 ms |
| 95d0636 | 1243.73 ms | 1245.54 ms | 1.81 ms |
| ad69abc | 1259.00 ms | 1261.60 ms | 2.60 ms |
| f25f207 | 1233.44 ms | 1260.73 ms | 27.30 ms |
| b44db8f | 1255.29 ms | 1258.90 ms | 3.61 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8fa3934 | 8.09 MiB | 9.07 MiB | 1000.86 KiB |
| 4ad2751 | 8.29 MiB | 9.39 MiB | 1.10 MiB |
| 5112c69 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| ef31c7f | 8.09 MiB | 9.07 MiB | 1000.79 KiB |
| a61674e | 8.10 MiB | 9.16 MiB | 1.07 MiB |
| cd16818 | 8.28 MiB | 9.33 MiB | 1.05 MiB |
| 95d0636 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
| ad69abc | 8.10 MiB | 9.08 MiB | 1004.37 KiB |
| f25f207 | 8.32 MiB | 9.38 MiB | 1.05 MiB |
| b44db8f | 8.29 MiB | 9.37 MiB | 1.08 MiB |
Previous results on branch: feat/spotlight
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 00dba0d | 1227.12 ms | 1248.90 ms | 21.77 ms |
| 3a985bd | 1209.90 ms | 1229.49 ms | 19.59 ms |
| 6784f06 | 1225.35 ms | 1258.41 ms | 33.06 ms |
| e864406 | 1232.06 ms | 1247.16 ms | 15.10 ms |
| b93288a | 1210.67 ms | 1224.23 ms | 13.56 ms |
| 4ee46f7 | 1240.34 ms | 1270.79 ms | 30.45 ms |
| 574550e | 1240.98 ms | 1251.63 ms | 10.65 ms |
| 52e500e | 1242.49 ms | 1263.70 ms | 21.21 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 00dba0d | 8.32 MiB | 9.38 MiB | 1.05 MiB |
| 3a985bd | 8.32 MiB | 9.38 MiB | 1.05 MiB |
| 6784f06 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
| e864406 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
| b93288a | 8.32 MiB | 9.38 MiB | 1.06 MiB |
| 4ee46f7 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
| 574550e | 8.32 MiB | 9.38 MiB | 1.05 MiB |
| 52e500e | 8.32 MiB | 9.38 MiB | 1.05 MiB |
stefanosiano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add the tests, and move tests accordingly based on how you moved the code between classes
Looks great for the rest!
Adds Flutter Spotlight support
Added options
spotlightUsage:
FYI: screenshots cannot be processed currently by the spotlight overlay so we remove the attachment from the envelope before sending it. getsentry/spotlight#274
Closes #1784