minor cleanup (#7)

Author: zoechi

lib/sentry.dart

@@ -29,7 +29,7 @@ class SentryClient {
   /// The default logger name used if no other value is supplied.
   static const String defaultLoggerName = 'SentryClient';
 
-  /// Instantiates a client using [dns] issued to your project by Sentry.io as
+  /// Instantiates a client using [dsn] issued to your project by Sentry.io as
   /// the endpoint for submitting events.
   ///
   /// [environmentAttributes] contain event attributes that do not change over
@@ -161,7 +161,7 @@ class SentryClient {
           'sentry_secret=$secretKey',
     };
 
-    Map<String, dynamic> json = <String, dynamic>{
+    final Map<String, dynamic> json = <String, dynamic>{
       'project': projectId,
       'event_id': _uuidGenerator(),
       'timestamp': formatDateAsIso8601WithSecondPrecision(_clock.now()),
@@ -221,15 +221,13 @@ class SentryClient {
 /// contain the description of the error.
 @immutable
 class SentryResponse {
-  SentryResponse.success({@required eventId})
+  const SentryResponse.success({@required this.eventId})
       : isSuccessful = true,
-        eventId = eventId,
         error = null;
 
-  SentryResponse.failure(error)
+  const SentryResponse.failure(this.error)
       : isSuccessful = false,
-        eventId = null,
-        error = error;
+        eventId = null;
 
   /// Whether event was submitted successfully.
   final bool isSuccessful;
@@ -243,9 +241,8 @@ class SentryResponse {
 
 typedef UuidGenerator = String Function();
 
-String _generateUuidV4WithoutDashes() {
-  return new Uuid().generateV4().replaceAll('-', '');
-}
+String _generateUuidV4WithoutDashes() =>
+    new Uuid().generateV4().replaceAll('-', '');
 
 /// Severity of the logged [Event].
 @immutable
@@ -276,7 +273,7 @@ class Event {
   static const String defaultFingerprint = '{{ default }}';
 
   /// Creates an event.
-  Event({
+  const Event({
     this.loggerName,
     this.serverName,
     this.release,

lib/src/stack_trace.dart

@@ -10,7 +10,7 @@ const Map<String, dynamic> asynchronousGapFrameJson = const <String, dynamic>{
   'abs_path': '<asynchronous suspension>',
 };
 
-/// Encodes [strackTrace] as JSON in the Sentry.io format.
+/// Encodes [stackTrace] as JSON in the Sentry.io format.
 ///
 /// [stackTrace] must be [String] or [StackTrace].
 List<Map<String, dynamic>> encodeStackTrace(dynamic stackTrace) {

lib/src/utils.dart

@@ -12,7 +12,7 @@ void mergeAttributes(Map<String, dynamic> attributes,
     {@required Map<String, dynamic> into}) {
   assert(attributes != null && into != null);
   attributes.forEach((String name, dynamic value) {
-    dynamic targetValue = into[name];
+    final dynamic targetValue = into[name];
     if (value is Map && targetValue is Map) {
       mergeAttributes(value, into: targetValue);
     } else {

test/sentry_test.dart

@@ -46,7 +46,7 @@ void main() {
         clock: fakeClock,
         uuidGenerator: () => 'X' * 32,
         compressPayload: compressPayload,
-        environmentAttributes: new Event(
+        environmentAttributes: const Event(
           serverName: 'test.server.com',
           release: '1.2.3',
           environment: 'staging',
@@ -65,7 +65,7 @@ void main() {
 
       expect(postUri, client.postUri);
 
-      Map<String, String> expectedHeaders = <String, String>{
+      final Map<String, String> expectedHeaders = <String, String>{
         'User-Agent': '$sdkName/$sdkVersion',
         'Content-Type': 'application/json',
         'X-Sentry-Auth': 'Sentry sentry_version=6, '
@@ -86,7 +86,7 @@ void main() {
         json = JSON.decode(UTF8.decode(body));
       }
       final Map<String, dynamic> stacktrace = json.remove('stacktrace');
-      expect(stacktrace['frames'], new isInstanceOf<List>());
+      expect(stacktrace['frames'], const isInstanceOf<List>());
       expect(stacktrace['frames'], isNotEmpty);
 
       final Map<String, dynamic> topFrame = stacktrace['frames'].first;
@@ -141,7 +141,7 @@ void main() {
         clock: fakeClock,
         uuidGenerator: () => 'X' * 32,
         compressPayload: false,
-        environmentAttributes: new Event(
+        environmentAttributes: const Event(
           serverName: 'test.server.com',
           release: '1.2.3',
           environment: 'staging',