Skip to content

Commit 2dce393

Browse files
denrasedenrase
committed
format
1 parent e04bec3 commit 2dce393

File tree

6 files changed

+41
-45
lines changed

6 files changed

+41
-45
lines changed

‎flutter/lib/src/integrations/connectivity/connectivity_integration.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,3 @@ class ConnectivityIntegration extends Integration<SentryFlutterOptions> {
3434
);
3535
}
3636
}
37-
38-

‎flutter/lib/src/integrations/connectivity/connectivity_provider.dart‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
21
import 'noop_connectivity_provider.dart'
3-
if (dart.library.html) 'web_connectivity_provider.dart';
2+
if (dart.library.html) 'web_connectivity_provider.dart';
43

54
abstract class ConnectivityProvider {
65
factory ConnectivityProvider() => connectivityProvider();

‎flutter/lib/src/integrations/connectivity/noop_connectivity_provider.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
1-
21
import 'connectivity_provider.dart';
32

43
ConnectivityProvider connectivityProvider() {
54
return NoOpConnectivityProvider();
65
}
76

87
class NoOpConnectivityProvider implements ConnectivityProvider {
9-
108
@override
119
void listen(void Function(String connectivity) onChange) {
1210
// NoOp

‎flutter/lib/src/integrations/connectivity/web_connectivity_provider.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ ConnectivityProvider connectivityProvider() {
88
}
99

1010
class WebConnectivityProvider implements ConnectivityProvider {
11-
1211
StreamSubscription<html.Event>? _onOnlineSub;
1312
StreamSubscription<html.Event>? _onOfflineSub;
1413

‎flutter/test/integrations/connectivity_integration_test.dart‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@ void main() {
3232
true);
3333
});
3434

35-
test(
36-
'$ConnectivityIntegration: addsBreadcrumb',
37-
() {
35+
test('$ConnectivityIntegration: addsBreadcrumb', () {
3836
final integration = fixture.getSut();
3937
integration.call(fixture.hub, fixture.options);
4038

‎flutter/test/sentry_flutter_test.dart‎

Lines changed: 39 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ final platformAgnosticIntegrations = [
2424
SentryViewHierarchyIntegration,
2525
];
2626

27+
final webIntegrations = [
28+
ConnectivityIntegration,
29+
];
30+
2731
final nonWebIntegrations = [
2832
OnErrorIntegration,
2933
];
@@ -44,11 +48,6 @@ final nativeIntegrations = [
4448
NativeSdkIntegration,
4549
];
4650

47-
// These should be added to every platform except Android & iOS/macOS.
48-
final nonMobileIntegrations = [
49-
ConnectivityIntegration,
50-
];
51-
5251
void main() {
5352
TestWidgetsFlutterBinding.ensureInitialized();
5453

@@ -87,17 +86,17 @@ void main() {
8786
options: sentryFlutterOptions!, expectedHasNativeScopeObserver: true);
8887

8988
testConfiguration(
90-
integrations: integrations,
91-
shouldHaveIntegrations: [
92-
...androidIntegrations,
93-
...nativeIntegrations,
94-
...platformAgnosticIntegrations,
95-
...nonWebIntegrations,
96-
],
97-
shouldNotHaveIntegrations: [
98-
...iOsAndMacOsIntegrations,
99-
...nonWebIntegrations,
100-
],
89+
integrations: integrations,
90+
shouldHaveIntegrations: [
91+
...androidIntegrations,
92+
...nativeIntegrations,
93+
...platformAgnosticIntegrations,
94+
...nonWebIntegrations,
95+
],
96+
shouldNotHaveIntegrations: [
97+
...iOsAndMacOsIntegrations,
98+
...nonWebIntegrations,
99+
],
101100
);
102101

103102
integrations
@@ -192,19 +191,15 @@ void main() {
192191
testScopeObserver(
193192
options: sentryFlutterOptions!, expectedHasNativeScopeObserver: true);
194193

195-
testConfiguration(
196-
integrations: integrations,
197-
shouldHaveIntegrations: [
198-
...iOsAndMacOsIntegrations,
199-
...nativeIntegrations,
200-
...platformAgnosticIntegrations,
201-
...nonWebIntegrations,
202-
],
203-
shouldNotHaveIntegrations: [
204-
...androidIntegrations,
205-
...nonWebIntegrations,
206-
]
207-
);
194+
testConfiguration(integrations: integrations, shouldHaveIntegrations: [
195+
...iOsAndMacOsIntegrations,
196+
...nativeIntegrations,
197+
...platformAgnosticIntegrations,
198+
...nonWebIntegrations,
199+
], shouldNotHaveIntegrations: [
200+
...androidIntegrations,
201+
...nonWebIntegrations,
202+
]);
208203

209204
testBefore(
210205
integrations: integrations,
@@ -250,12 +245,12 @@ void main() {
250245
shouldHaveIntegrations: [
251246
...platformAgnosticIntegrations,
252247
...nonWebIntegrations,
253-
...nonMobileIntegrations,
254248
],
255249
shouldNotHaveIntegrations: [
256250
...androidIntegrations,
257251
...iOsAndMacOsIntegrations,
258252
...nativeIntegrations,
253+
...webIntegrations,
259254
],
260255
);
261256

@@ -302,12 +297,12 @@ void main() {
302297
shouldHaveIntegrations: [
303298
...platformAgnosticIntegrations,
304299
...nonWebIntegrations,
305-
...nonMobileIntegrations,
306300
],
307301
shouldNotHaveIntegrations: [
308302
...androidIntegrations,
309303
...iOsAndMacOsIntegrations,
310304
...nativeIntegrations,
305+
...webIntegrations,
311306
],
312307
);
313308

@@ -356,7 +351,7 @@ void main() {
356351
integrations: integrations,
357352
shouldHaveIntegrations: [
358353
...platformAgnosticIntegrations,
359-
...nonMobileIntegrations,
354+
...webIntegrations,
360355
],
361356
shouldNotHaveIntegrations: [
362357
...androidIntegrations,
@@ -404,7 +399,10 @@ void main() {
404399

405400
testConfiguration(
406401
integrations: integrations,
407-
shouldHaveIntegrations: platformAgnosticIntegrations,
402+
shouldHaveIntegrations: [
403+
...platformAgnosticIntegrations,
404+
...webIntegrations,
405+
],
408406
shouldNotHaveIntegrations: [
409407
...androidIntegrations,
410408
...iOsAndMacOsIntegrations,
@@ -448,7 +446,10 @@ void main() {
448446

449447
testConfiguration(
450448
integrations: integrations,
451-
shouldHaveIntegrations: platformAgnosticIntegrations,
449+
shouldHaveIntegrations: [
450+
...platformAgnosticIntegrations,
451+
...webIntegrations,
452+
],
452453
shouldNotHaveIntegrations: [
453454
...androidIntegrations,
454455
...iOsAndMacOsIntegrations,
@@ -493,7 +494,10 @@ void main() {
493494

494495
testConfiguration(
495496
integrations: integrations,
496-
shouldHaveIntegrations: platformAgnosticIntegrations,
497+
shouldHaveIntegrations: [
498+
...platformAgnosticIntegrations,
499+
...webIntegrations,
500+
],
497501
shouldNotHaveIntegrations: [
498502
...androidIntegrations,
499503
...iOsAndMacOsIntegrations,

0 commit comments

Comments
 (0)