Update test

Author: buenaflor

flutter/lib/src/navigation/sentry_navigator_observer.dart

@@ -287,9 +287,14 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
     final routeName = _getRouteName(route) ?? _currentRouteName;
     final arguments = route?.settings.arguments;
 
+    // On Mobile (iOS/Android) and macOS we do want to skip because we have an app start integration
     // On Web we don't want to skip as we dont have a pageload / app start integration
-    // On mobile we do want to skip because we have an app start integration
-    final skipRoot = !_hub.options.platform.isWeb && routeName == '/';
+    // On Desktop platforms (Windows/Linux) we don't skip as they don't have app start integration
+    final skipRoot = !_hub.options.platform.isWeb &&
+        (_hub.options.platform.isIOS ||
+            _hub.options.platform.isAndroid ||
+            _hub.options.platform.isMacOS) &&
+        routeName == '/';
     if (!_enableAutoTransactions || routeName == null || skipRoot) {
       return;
     }

flutter/test/navigation/sentry_navigator_observer_test.dart

@@ -334,66 +334,6 @@ void main() {
       verify(span.setData('route_settings_arguments', arguments));
     });
 
-    test('root route does not start transaction on non-web', () async {
-      final rootRoute = route(RouteSettings(name: '/'));
-
-      final hub = _MockHub();
-      hub.options.platform = MockPlatform(isWeb: false);
-      final span = getMockSentryTracer();
-      when(span.context).thenReturn(SentrySpanContext(operation: 'op'));
-      when(span.finished).thenReturn(false);
-      when(span.status).thenReturn(SpanStatus.ok());
-      _whenAnyStart(hub, span);
-
-      final sut = fixture.getSut(hub: hub);
-
-      sut.didPush(rootRoute, null);
-      await Future<void>.delayed(const Duration(milliseconds: 100));
-
-      verifyNever(hub.startTransactionWithContext(
-        any,
-        startTimestamp: anyNamed('startTimestamp'),
-        waitForChildren: true,
-        autoFinishAfter: anyNamed('autoFinishAfter'),
-        trimEnd: true,
-        onFinish: anyNamed('onFinish'),
-      ));
-
-      await hub.configureScope((scope) {
-        expect(scope.span, null);
-      });
-    });
-
-    test('root route starts transaction on web', () async {
-      final rootRoute = route(RouteSettings(name: '/'));
-
-      final hub = _MockHub();
-      hub.options.platform = MockPlatform(isWeb: true);
-      final span = getMockSentryTracer();
-      when(span.context).thenReturn(SentrySpanContext(operation: 'op'));
-      when(span.finished).thenReturn(false);
-      when(span.status).thenReturn(SpanStatus.ok());
-      _whenAnyStart(hub, span);
-
-      final sut = fixture.getSut(hub: hub);
-
-      sut.didPush(rootRoute, null);
-      await Future<void>.delayed(const Duration(milliseconds: 100));
-
-      verify(hub.startTransactionWithContext(
-        any,
-        startTimestamp: anyNamed('startTimestamp'),
-        waitForChildren: true,
-        autoFinishAfter: anyNamed('autoFinishAfter'),
-        trimEnd: true,
-        onFinish: anyNamed('onFinish'),
-      ));
-
-      await hub.configureScope((scope) {
-        expect(scope.span, isNotNull);
-      });
-    });
-
     test('didPush sets current route name', () async {
       const name = 'Current Route';
       final currentRoute = route(RouteSettings(name: name));
@@ -484,6 +424,93 @@ void main() {
 
       expect(SentryNavigatorObserver.currentRouteName, 'Old Route');
     });
+
+    group('root route transaction behavior by platform', () {
+      // Platforms that skip root transactions (have app start integration)
+      final platformsWithAppStart = [
+        ('iOS', MockPlatform.iOS()),
+        ('Android', MockPlatform.android()),
+        ('macOS', MockPlatform.macOS(isWeb: false)),
+      ];
+
+      // Platforms that don't skip root transactions (no app start integration)
+      final platformsWithoutAppStart = [
+        ('Web', MockPlatform(isWeb: true)),
+        ('Linux', MockPlatform.linux(isWeb: false)),
+        ('Windows', MockPlatform.windows(isWeb: false)),
+      ];
+
+      void testRootRouteTransaction({
+        required String platformName,
+        required MockPlatform platform,
+        required bool shouldStartTransaction,
+      }) {
+        test(
+            'root route ${shouldStartTransaction ? 'starts' : 'does not start'} transaction on $platformName',
+            () async {
+          final rootRoute = route(RouteSettings(name: '/'));
+
+          final hub = _MockHub();
+          hub.options.platform = platform;
+          final span = getMockSentryTracer();
+          when(span.context).thenReturn(SentrySpanContext(operation: 'op'));
+          when(span.finished).thenReturn(false);
+          when(span.status).thenReturn(SpanStatus.ok());
+          _whenAnyStart(hub, span);
+
+          final sut = fixture.getSut(hub: hub);
+
+          sut.didPush(rootRoute, null);
+          await Future<void>.delayed(const Duration(milliseconds: 100));
+
+          if (shouldStartTransaction) {
+            verify(hub.startTransactionWithContext(
+              any,
+              startTimestamp: anyNamed('startTimestamp'),
+              waitForChildren: true,
+              autoFinishAfter: anyNamed('autoFinishAfter'),
+              trimEnd: true,
+              onFinish: anyNamed('onFinish'),
+            ));
+
+            await hub.configureScope((scope) {
+              expect(scope.span, isNotNull);
+            });
+          } else {
+            verifyNever(hub.startTransactionWithContext(
+              any,
+              startTimestamp: anyNamed('startTimestamp'),
+              waitForChildren: true,
+              autoFinishAfter: anyNamed('autoFinishAfter'),
+              trimEnd: true,
+              onFinish: anyNamed('onFinish'),
+            ));
+
+            await hub.configureScope((scope) {
+              expect(scope.span, null);
+            });
+          }
+        });
+      }
+
+      // Test platforms that skip root transactions
+      for (final (platformName, platform) in platformsWithAppStart) {
+        testRootRouteTransaction(
+          platformName: platformName,
+          platform: platform,
+          shouldStartTransaction: false,
+        );
+      }
+
+      // Test platforms that don't skip root transactions
+      for (final (platformName, platform) in platformsWithoutAppStart) {
+        testRootRouteTransaction(
+          platformName: platformName,
+          platform: platform,
+          shouldStartTransaction: true,
+        );
+      }
+    });
   });
 
   group('RouteObserverBreadcrumb', () {