feat(dif): Fail debug-files upload when file is too big
#2331
+83
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/dif-too-big-error
branch
2 times, most recently
from
d447e10 to
08d6e45
Compare
szokeasaurusrex
commented
Jan 3, 2025
| MockEndpointBuilder::new("GET", "/api/0/organizations/wat-org/chunk-upload/") | ||
| .with_response_file("debug_files/get-chunk-upload-small-max-size.json"), | ||
| ) | ||
| .assert_cmd(vec!["debug-files", "upload", "tests/integration/_fixtures/SrcGenSampleApp.pdb"]) |
There was a problem hiding this comment.
This file is about 11 KiB, exceeding the maximum size of 2 KiB
szokeasaurusrex
force-pushed
the
szokeasaurusrex/dif-too-big-error
branch
from
08d6e45 to
bb06bc8
Compare
loewenheim
approved these changes
Jan 7, 2025
szokeasaurusrex
force-pushed
the
szokeasaurusrex/dif-too-big-error
branch
from
bb06bc8 to
7765932
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/dif-validation-handle
branch
from
275c5ea to
ad7e037
Compare
Base automatically changed from
szokeasaurusrex/dif-validation-handle
to
master
January 7, 2025 11:32
Previously, we only logged an easy-to-miss warning when we had to skip uploading a debug file because it was too big. Now, we instead fail the entire upload loudly, to ensure users do not miss this important information. Also, add tests to verify the new behavior. Resolves #2313
szokeasaurusrex
force-pushed
the
szokeasaurusrex/dif-too-big-error
branch
from
7765932 to
7153e89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only logged an easy-to-miss warning when we had to skip uploading a debug file because it was too big. Now, we instead fail the entire upload loudly, to ensure users do not miss this important information.
Depends on:
Resolves #2313