ref: Transition to binaries over npm #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
commented
Nov 24, 2023
| @@ -27,7 +27,7 @@ | |||
| "eslint-config-prettier": "^8.5.0", | |||
| "jest": "^27.5.1", | |||
| "npm-run-all": "^4.1.5", | |||
| "prettier": "^2.6.2" | |||
| "prettier": "2.8.8" | |||
There was a problem hiding this comment.
I pinned this because CI and local were drifting apart for some reason. :/
AbhiPrasad
approved these changes
Nov 24, 2023
lforst
changed the title
|
Just verified with @bitsandfoxes on Windows and it works 👌 |
|
|
2 tasks
AbhiPrasad
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 5, 2023
Take advantage of new binary distribution in getsentry/sentry-cli#1836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively moves us over to the new npm binary distributions.
Changes:
Resolves #1360
Fixes #1758
Fixes #1640
Resolves #1348
Fixes getsentry/sentry-javascript#9545
Ref getsentry/sentry-javascript-bundler-plugins#412 (comment)