Skip to content

Commit d424014

Browse files
runningcodeclaude
andcommitted
Address remaining review feedback from szokeasaurusrex
- Remove explicit type annotation from get_one() call - Move test into proper mod tests block with #[cfg(test)] Addresses the final review comments on the PR. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 89caadc commit d424014

File tree

2 files changed

+21
-16
lines changed

2 files changed

+21
-16
lines changed

src/commands/build/upload.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
177177
let base_sha = matches.get_one("base_sha").map(String::as_str);
178178
let base_ref = matches.get_one("base_ref").map(String::as_str);
179179
let pr_number = matches
180-
.get_one::<u32>("pr_number")
180+
.get_one("pr_number")
181181
.copied()
182182
.or_else(get_github_pr_number);
183183

src/utils/vcs.rs

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1267,19 +1267,24 @@ fn test_git_repo_head_ref() {
12671267
);
12681268
}
12691269

1270-
#[test]
1271-
fn test_get_github_pr_number() {
1272-
std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
1273-
std::env::set_var("GITHUB_REF", "refs/pull/123/merge");
1274-
let pr_number = get_github_pr_number();
1275-
assert_eq!(pr_number, Some(123));
1276-
std::env::set_var("GITHUB_EVENT_NAME", "push");
1277-
let pr_number = get_github_pr_number();
1278-
assert_eq!(pr_number, None);
1279-
std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
1280-
std::env::set_var("GITHUB_REF", "refs/heads/main");
1281-
let pr_number = get_github_pr_number();
1282-
assert_eq!(pr_number, None);
1283-
std::env::remove_var("GITHUB_EVENT_NAME");
1284-
std::env::remove_var("GITHUB_REF");
1270+
#[cfg(test)]
1271+
mod tests {
1272+
use super::*;
1273+
1274+
#[test]
1275+
fn test_get_github_pr_number() {
1276+
std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
1277+
std::env::set_var("GITHUB_REF", "refs/pull/123/merge");
1278+
let pr_number = get_github_pr_number();
1279+
assert_eq!(pr_number, Some(123));
1280+
std::env::set_var("GITHUB_EVENT_NAME", "push");
1281+
let pr_number = get_github_pr_number();
1282+
assert_eq!(pr_number, None);
1283+
std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
1284+
std::env::set_var("GITHUB_REF", "refs/heads/main");
1285+
let pr_number = get_github_pr_number();
1286+
assert_eq!(pr_number, None);
1287+
std::env::remove_var("GITHUB_EVENT_NAME");
1288+
std::env::remove_var("GITHUB_REF");
1289+
}
12851290
}

0 commit comments

Comments
 (0)