Fixed sudo check

Author: mitsuhiko

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "sentry-cli"
-version = "0.3.0"
+version = "0.4.0"
 authors = ["Armin Ronacher <armin.ronacher@active-4.com>"]
 
 [lib]

src/sentrycli/commands/update.rs

@@ -13,6 +13,7 @@ use hyper::method::Method;
 use url::Url;
 use serde_json;
 
+use utils;
 use CliResult;
 use commands::Config;
 
@@ -117,7 +118,7 @@ pub fn make_app<'a, 'b: 'a>(app: App<'a, 'b>) -> App<'a, 'b>
 
 pub fn execute<'a>(_matches: &ArgMatches<'a>, _config: &Config) -> CliResult<()> {
     let exe = env::current_exe()?;
-    let need_sudo = fs::metadata(&exe)?.permissions().readonly();
+    let need_sudo = !utils::is_writable(&exe);
     let latest_release = get_latest_release()?;
     let tmp_path = if need_sudo {
         env::temp_dir().join(".sentry-cli.part")
@@ -132,8 +133,7 @@ pub fn execute<'a>(_matches: &ArgMatches<'a>, _config: &Config) -> CliResult<()>
         return Ok(());
     }
 
-    println!("Executable location: {}", exe.display());
-    println!("Download URL: {}", latest_release.download_url);
+    println!("Updating executable at {}", exe.display());
 
     match download_url(&latest_release.download_url, &tmp_path) {
         Err(err) => {

src/sentrycli/utils.rs

@@ -86,3 +86,7 @@ pub fn get_sha1_checksum(path: &Path) -> CliResult<String> {
     }
     Ok(sha.hexdigest())
 }
+
+pub fn is_writable<P: AsRef<Path>>(path: P) -> bool {
+    fs::OpenOptions::new().write(true).open(&path).map(|_| true).unwrap_or(false)
+}