Skip to content

Commit 2f13f81

Browse files
ref(sourcemaps): Fix unnecessary_wraps for add_sourcemap_references (#2368)
Ref #2357
1 parent 06fdfd6 commit 2f13f81

File tree

5 files changed

+6
-8
lines changed

5 files changed

+6
-8
lines changed

src/commands/react_native/appcenter.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
178178
}
179179

180180
processor.rewrite(&[here_str])?;
181-
processor.add_sourcemap_references()?;
181+
processor.add_sourcemap_references();
182182

183183
let chunk_upload_options = api.authenticated()?.get_chunk_upload_options(&org)?;
184184

src/commands/react_native/gradle.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
109109
}
110110

111111
processor.rewrite(&[base.to_str().unwrap()])?;
112-
processor.add_sourcemap_references()?;
112+
processor.add_sourcemap_references();
113113
processor.add_debug_id_references()?;
114114

115115
let version = matches.get_one::<String>("release");

src/commands/react_native/xcode.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
329329
ReleaseFileSearch::collect_file(sourcemap_path)?,
330330
);
331331
processor.rewrite(&[base.parent().unwrap().to_str().unwrap()])?;
332-
processor.add_sourcemap_references()?;
332+
processor.add_sourcemap_references();
333333
processor.add_debug_id_references()?;
334334

335335
let api = Api::current();

src/commands/sourcemaps/upload.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ fn process_sources_from_bundle(
327327
debug!("Prefixes: {:?}", prefixes);
328328

329329
processor.rewrite(&prefixes)?;
330-
processor.add_sourcemap_references()?;
330+
processor.add_sourcemap_references();
331331
processor.add_debug_id_references()?;
332332

333333
Ok(())
@@ -404,7 +404,7 @@ fn process_sources_from_paths(
404404
}
405405

406406
if !matches.get_flag("no_sourcemap_reference") {
407-
processor.add_sourcemap_references()?;
407+
processor.add_sourcemap_references();
408408
}
409409

410410
if matches.get_flag("debug_id_reference") {

src/utils/sourcemaps.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -690,8 +690,7 @@ impl SourceMapProcessor {
690690
}
691691

692692
/// Adds sourcemap references to all minified files
693-
#[expect(clippy::unnecessary_wraps)]
694-
pub fn add_sourcemap_references(&mut self) -> Result<()> {
693+
pub fn add_sourcemap_references(&mut self) {
695694
self.flush_pending_sources();
696695
self.collect_sourcemap_references();
697696

@@ -705,7 +704,6 @@ impl SourceMapProcessor {
705704
source.set_sourcemap_reference(sourcemap.url.to_string());
706705
}
707706
}
708-
Ok(())
709707
}
710708

711709
/// Adds debug id to the source file headers from the linked source map.

0 commit comments

Comments
 (0)