This repository was archived by the owner on Aug 30, 2023. It is now read-only.
fix: Migrate identity key from email -> sub #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcramer
approved these changes
Nov 16, 2017
|
@dcramer this is actually a breaking change since it uses something new in sentry. I assume we probably want this to be backwards compatible yes? |
|
@evanpurkhiser for older versions of sentry? no dont bother |
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
- Coverage 61.78% 61.63% -0.15%
==========================================
Files 8 8
Lines 157 159 +2
==========================================
+ Hits 97 98 +1
- Misses 60 61 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: getsentry/sentry#6577