This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Log stacktraces in SystemOutLogger #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
bruno-garcia
approved these changes
Jul 29, 2020
marandaneto
reviewed
Jul 30, 2020
marandaneto
approved these changes
Jul 30, 2020
Contributor
marandaneto
left a comment
marandaneto
left a comment
There was a problem hiding this comment.
LGTM, thanks @maciejwalkowiak
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Log stacktraces in SystemOutLogger when exception occurs.
💡 Motivation and Context
With
debugmode on, when exception happens it's currently difficult to find out why and where did it happen. With stacktraces printed to the console we can easily find the bug.💚 How did you test it?
📝 Checklist
🔮 Next steps