This repository was archived by the owner on Aug 30, 2023. It is now read-only.
fix: contexts serializer avoids reflection and fixes desugaring issue #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
bruno-garcia
approved these changes
Jul 3, 2020
Member
bruno-garcia
left a comment
bruno-garcia
left a comment
There was a problem hiding this comment.
Good one. Maybe we need this for Extra too?
Contributor
Author
no, this only happens when it extends the thread-safe version of it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
fix: contexts serializer avoids reflection and fixes desugaring issue
💡 Motivation and Context
#476
💚 How did you test it?
running it, tests are already in place
📝 Checklist
🔮 Next steps