-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalidate instrumentation cache when changing instrumentation features #753
Conversation
…ry to allow invalidating cache on change to these flags, add test
@romtsn do you wanna review this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Invalidate instrumentation cache when changing instrumentation features ([#753](https://github.com/getsentry/sentry-android-gradle-plugin/pull/753)) If none of the above apply, you can opt out of this check by adding |
📜 Description
Add
features
,logcatEnabled
andappStartEnabled
params toSpanAddingClassVisitorFactory
parameters to make sure that if these change, the instrumentation is run again and the cache is invalidated.💡 Motivation and Context
Currently, when instrumentation parameters
features
,logcatEnabled
orappStartEnabled
change, instrumentation is not run again and the cached instrumentation result is used. I.e. it is not possible to change the feature set without deleting the gradle cache in the home directory.Fixes #3595
💚 How did you test it?
Added automated test
📝 Checklist
🔮 Next steps