Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto install and instrument sentry-okhttp instead of sentry-android-okhttp on v7+ #724

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

stefanosiano
Copy link
Member

📜 Description

Added auto installation of sentry-okhttp only (without sentry-android-okhttp) when using sentry 7+
Auto instrumented sentry-okhttp directly instead of sentry-android-okhttp when using sentry 7+
When using older version, nothing changed

💡 Motivation and Context

Closes second step of #601
We want to remove the sentry-android-okhttp artifact and rely solely on sentry-okhttp

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

add sentry-okhttp module to autoInstall if Sentry v7+
changed OkHttp instrumentation to use sentry-okhttp instead of sentry-android-okhttp if Sentry v7+
fixed formatting
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c0af5ec

@stefanosiano stefanosiano marked this pull request as ready for review June 20, 2024 15:29
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

stefanosiano and others added 2 commits June 21, 2024 16:57
…all/okhttp/AndroidOkHttpInstallStrategy.kt

Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>
@stefanosiano stefanosiano merged commit a50beb1 into main Jun 21, 2024
18 checks passed
@stefanosiano stefanosiano deleted the feat/remove-sentry-android-okhttp branch June 21, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants