Skip to content

Conversation

@romtsn
Copy link
Member

@romtsn romtsn commented Nov 7, 2025

Same as #60 but implements the necessary changes for outline and outlineCallsite in ProguardCache

Closes #59

@romtsn romtsn requested a review from loewenheim November 7, 2025 13:22
Copy link
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. This comment applies here too but other than that this looks great!

Base automatically changed from rz/feat/outline-call-site-support to master November 10, 2025 10:14
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 81.15942% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.40%. Comparing base (5cfabb2) to head (bca9be2).
⚠️ Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
src/cache/mod.rs 73.68% 35 Missing ⚠️
src/cache/raw.rs 95.89% 3 Missing ⚠️
src/cache/debug.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   77.72%   78.40%   +0.67%     
==========================================
  Files           7        8       +1     
  Lines        2272     2514     +242     
==========================================
+ Hits         1766     1971     +205     
- Misses        506      543      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@loewenheim
Copy link
Contributor

Oh, forgot to mention: can you add a changelog entry for this feature?

@romtsn romtsn merged commit 305eabd into master Nov 10, 2025
7 checks passed
@romtsn romtsn deleted the rz/feat/outline-call-site-support-cache branch November 10, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support outline and outlineCallsite member annotations

3 participants