Skip to content

feat(r8): Support outline and outlineCallsite annotations in ProguardMapping #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romtsn merged 7 commits into from
Nov 10, 2025
Merged

feat(r8): Support outline and outlineCallsite annotations in ProguardMapping #60

romtsn merged 7 commits into from
Nov 10, 2025

Conversation

@romtsn
Copy link
Member

@romtsn romtsn commented Oct 23, 2025

This only targets ProguardMapping at the moment, will address ProguardCache in a separate PR

Part of #59

@romtsn romtsn requested a review from loewenheim October 23, 2025 12:47
@romtsn romtsn changed the title feat(r8): Support outline and outlineCallsite annotations feat(r8): Support outline and outlineCallsite annotations in ProguardMapping Oct 23, 2025
@romtsn romtsn force-pushed the rz/feat/outline-call-site-support branch from 9f5dce1 to 89f48d0 Compare October 24, 2025 09:58
@romtsn romtsn changed the base branch from master to rz/build/fix-compiler-warnings October 24, 2025 09:58
@romtsn romtsn force-pushed the rz/feat/outline-call-site-support branch from 89f48d0 to d0d9507 Compare October 24, 2025 10:02
Base automatically changed from rz/build/fix-compiler-warnings to master October 24, 2025 10:05
@romtsn romtsn force-pushed the rz/feat/outline-call-site-support branch from d0d9507 to 151753b Compare October 24, 2025 10:06
loewenheim
loewenheim reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, but it's going to need more work, see the comments about outline call site records.

@romtsn romtsn mentioned this pull request Nov 7, 2025
Merged
loewenheim
loewenheim reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than disentangling the prepare_frame_for_mapping function this looks good now.

@romtsn romtsn merged commit ce3f3c9 into master Nov 10, 2025
7 checks passed
@romtsn romtsn deleted the rz/feat/outline-call-site-support branch November 10, 2025 10:14
romtsn added a commit that referenced this pull request Nov 10, 2025
@romtsn
feat(r8): Support outline and outlineCallsite annotations in Proguard…
305eabd 
…Cache (#62)

Same as #60 but implements the necessary changes for `outline` and
`outlineCallsite` in ProguardCache

Closes #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loewenheim loewenheim loewenheim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romtsn @loewenheim