ref: Parse ProGuard files smarter #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
commented
Jul 7, 2025
Comment on lines
-21
to
-25
| StackFrame::with_file( | ||
| StackFrame::new( | ||
| "io.sentry.samples.instrumentation.ui.EditActivity", | ||
| "onCreate$lambda$1", | ||
| 37, | ||
| "EditActivity", |
Contributor
Author
There was a problem hiding this comment.
Removing the file names from these frames is correct—the previously returned file names were wrong and an example of the sort of bug this PR is meant to address.
Swatinem
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
ProguardCacheandProguardMapperboth implemented their (structurally very similar) parsing functions. These parsing functions left a lot to be desired; the simply took records in the order they were encountered and were unable to use later information to refine previously encountered information.This PR splits the parsing logic out into a new module
builder(please feel free to bikeshed about this), which contains a bunch of auxiliary types and the mainParsedProguardMappingtype.ParsedProguardMappingcan then in turn be processed into aProguardMapperorProguardCache, as required.Fixes #54. Fixes RUSTPRO-4.
As a follow-up I would like to use the newly introduced
ObfuscatedNameandOriginalNametypes throughout the crate.