enhance: make mapping by params initialization optional #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
reviewed
Nov 30, 2023
add a new new_with_param_mapping constructor that allows specifying a bool
Swatinem
approved these changes
Nov 30, 2023
viglia
deleted the
viglia/enhance/make-mapping-by-params-initialization-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most of the use cases where line numbers are provided it's not necessary to keep the extra
mappings_by_paramshashmap.This make the
mappings_by_paramsinitialization optional to improve both the parsing speed and the memory consumpion.