Skip to content

Commit fa0ac53

Browse files
authored
fix(utils): Safely access node.nodeType (#243)
Access to `node.nodeType` can throw on FF when using the internal screenshot tool. closes getsentry/sentry-javascript#15559
1 parent 833381c commit fa0ac53

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

packages/rrweb/src/utils.ts

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -229,11 +229,17 @@ export function closestElementOfNode(node: Node | null): HTMLElement | null {
229229
if (!node) {
230230
return null;
231231
}
232-
const el: HTMLElement | null =
233-
node.nodeType === node.ELEMENT_NODE
234-
? (node as HTMLElement)
235-
: node.parentElement;
236-
return el;
232+
233+
// Catch access to node properties to avoid Firefox "permission denied" errors
234+
try {
235+
const el: HTMLElement | null =
236+
node.nodeType === node.ELEMENT_NODE
237+
? (node as HTMLElement)
238+
: node.parentElement;
239+
return el;
240+
} catch (error) {
241+
return null;
242+
}
237243
}
238244

239245
/**

0 commit comments

Comments
 (0)