This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Add sample_rate configuration #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobenolt
reviewed
Mar 9, 2017
docs/advanced.rst
Outdated
| .. code-block:: python | ||
|
|
||
| # send 50% of events | ||
| sample_rate = 5.0 |
There was a problem hiding this comment.
Doesn't this contradict what the description says? 0.5 would be sending 50% of events. I didn't read the code to see how it' simplemented though, so not sure which one is accurate.
dcramer
force-pushed
the
feature/sample-rate
branch
from
87d4987 to
3542978
Compare
bretthoerner
approved these changes
Mar 9, 2017
tkaemming
reviewed
Mar 9, 2017
| @@ -627,7 +631,9 @@ def capture(self, event_type, data=None, date=None, time_spent=None, | |||
| event_type, data, date, time_spent, extra, stack, tags=tags, | |||
| **kwargs) | |||
|
|
|||
| self.send(**data) | |||
| # should this event be sampled? | |||
| if self._random.random() <= self.sample_rate: | |||
There was a problem hiding this comment.
Technically this is lower bound inclusive, so a sample rate of 0.0 can still result in an event being sent. It'd be safer/more correct to make this comparison <. 🤓
This was referenced Mar 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.