feat: enhance flavor configuration and add tests for non-conventional PR titles

Author: vaind

CHANGELOG.md

@@ -4,7 +4,7 @@
 
 ### Features
 
-- Danger - Improve testing infrastructure and conventional commit scope handling ([#105](https://github.com/getsentry/github-workflows/pull/105))
+- Danger - Improve conventional commit scope handling, and non-conventional PR title support ([#105](https://github.com/getsentry/github-workflows/pull/105))
 - Add Proguard artifact endpoint for Android builds in sentry-server ([#100](https://github.com/getsentry/github-workflows/pull/100))
 
 ### Security

danger/dangerfile-utils.js

@@ -1,12 +1,12 @@
 /// Unified configuration for PR flavors (based on real Sentry usage analysis)
 const FLAVOR_CONFIG = [
   {
-    labels: ["feat", "feature"],
+    labels: ["feat", "feature", "add", "implement"],
     changelog: "Features",
     isFeature: true
   },
   {
-    labels: ["fix", "bug", "bugfix"],
+    labels: ["fix", "bug", "bugfix", "resolve", "correct"],
     changelog: "Fixes"
   },
   {
@@ -33,7 +33,11 @@ const FLAVOR_CONFIG = [
       "chore",
       "meta",
       "deps",
-      "dep"
+      "dep",
+      "update",
+      "bump",
+      "cleanup",
+      "format"
     ]
   }
 ];
@@ -60,11 +64,19 @@ function getFlavorConfig(prFlavor) {
 function extractPRFlavor(prTitle, prBranchRef) {
   // Validate input parameters to prevent runtime errors
   if (prTitle && typeof prTitle === 'string') {
-    const parts = prTitle.split(":");
-    if (parts.length > 1) {
-      return parts[0].toLowerCase().trim();
+    // First try conventional commit format: "type(scope): description"
+    const colonParts = prTitle.split(":");
+    if (colonParts.length > 1) {
+      return colonParts[0].toLowerCase().trim();
+    }
+
+    // Fallback: try first word for non-conventional titles like "fix memory leak"
+    const firstWord = prTitle.trim().split(/\s+/)[0];
+    if (firstWord) {
+      return firstWord.toLowerCase();
     }
   }
+
   if (prBranchRef && typeof prBranchRef === 'string') {
     const parts = prBranchRef.split("/");
     if (parts.length > 1) {

danger/dangerfile-utils.test.js

@@ -100,6 +100,37 @@ describe('dangerfile-utils', () => {
       const multipleParens = getFlavorConfig('feat(scope1)(scope2)');
       assert.strictEqual(multipleParens.changelog, 'Features'); // Should strip at first (
     });
+
+    it('should handle non-conventional action words', () => {
+      // Feature-related words
+      const addConfig = getFlavorConfig('add');
+      assert.strictEqual(addConfig.changelog, 'Features');
+      assert.strictEqual(addConfig.isFeature, true);
+
+      const implementConfig = getFlavorConfig('implement');
+      assert.strictEqual(implementConfig.changelog, 'Features');
+      assert.strictEqual(implementConfig.isFeature, true);
+
+      // Fix-related words
+      const resolveConfig = getFlavorConfig('resolve');
+      assert.strictEqual(resolveConfig.changelog, 'Fixes');
+
+      const correctConfig = getFlavorConfig('correct');
+      assert.strictEqual(correctConfig.changelog, 'Fixes');
+
+      // Internal change words
+      const updateConfig = getFlavorConfig('update');
+      assert.strictEqual(updateConfig.changelog, undefined);
+
+      const bumpConfig = getFlavorConfig('bump');
+      assert.strictEqual(bumpConfig.changelog, undefined);
+
+      const cleanupConfig = getFlavorConfig('cleanup');
+      assert.strictEqual(cleanupConfig.changelog, undefined);
+
+      const formatConfig = getFlavorConfig('format');
+      assert.strictEqual(formatConfig.changelog, undefined);
+    });
   });
 
   describe('extractPRFlavor', () => {
@@ -131,14 +162,20 @@ describe('dangerfile-utils', () => {
     });
 
     it('should return empty string if no flavor found', () => {
-      const flavor1 = extractPRFlavor('Simple title', null);
+      // Empty or whitespace-only strings
+      const flavor1 = extractPRFlavor('', null);
       assert.strictEqual(flavor1, '');
 
-      const flavor2 = extractPRFlavor(null, 'simple-branch');
+      const flavor2 = extractPRFlavor('   ', null);
       assert.strictEqual(flavor2, '');
 
-      const flavor3 = extractPRFlavor(null, null);
+      // No branch with slash
+      const flavor3 = extractPRFlavor(null, 'simple-branch');
       assert.strictEqual(flavor3, '');
+
+      // All null/undefined
+      const flavor4 = extractPRFlavor(null, null);
+      assert.strictEqual(flavor4, '');
     });
 
     it('should handle edge cases', () => {
@@ -172,6 +209,32 @@ describe('dangerfile-utils', () => {
       const flavor5 = extractPRFlavor('valid: title', 42);
       assert.strictEqual(flavor5, 'valid');
     });
+
+    it('should extract first word from non-conventional PR titles', () => {
+      // Non-conventional titles starting with action words
+      const flavor1 = extractPRFlavor('Fix memory leak in authentication', null);
+      assert.strictEqual(flavor1, 'fix');
+
+      const flavor2 = extractPRFlavor('Add support for new API endpoint', null);
+      assert.strictEqual(flavor2, 'add');
+
+      const flavor3 = extractPRFlavor('Update dependencies to latest versions', null);
+      assert.strictEqual(flavor3, 'update');
+
+      const flavor4 = extractPRFlavor('Remove deprecated configuration options', null);
+      assert.strictEqual(flavor4, 'remove');
+
+      const flavor5 = extractPRFlavor('Bump version to 2.0.0', null);
+      assert.strictEqual(flavor5, 'bump');
+
+      // Should still prefer conventional format over first word
+      const flavor6 = extractPRFlavor('chore: Update dependencies to latest versions', null);
+      assert.strictEqual(flavor6, 'chore');
+
+      // Handle extra whitespace
+      const flavor7 = extractPRFlavor('  Fix   memory   leak  ', null);
+      assert.strictEqual(flavor7, 'fix');
+    });
   });