Merge pull request #87 from getsentry/feat/crashpad_curl_response_body_log

supervacuus · web-flow · commit 432ff49ecccc · 2023-06-15T11:32:26.000+02:00
crashpad_handler: add response body to error log if status is not OK
diff --git a/util/net/http_transport_libcurl.cc b/util/net/http_transport_libcurl.cc
@@ -483,7 +483,8 @@ bool HTTPTransportLibcurl::ExecuteSynchronously(std::string* response_body) {
   }
 
   if (status != 200) {
-    LOG(ERROR) << base::StringPrintf("HTTP status %ld", status);
+    LOG(ERROR) << base::StringPrintf(
+        "HTTP status %ld, response = \"%s\"", status, response_body->c_str());
     return false;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -483,7 +483,8 @@ bool HTTPTransportLibcurl::ExecuteSynchronously(std::string* response_body) {`
`483`	`483`	`}`
`484`	`484`
`485`	`485`	`if (status != 200) {`
`486`		`- LOG(ERROR) << base::StringPrintf("HTTP status %ld", status);`
	`486`	`+ LOG(ERROR) << base::StringPrintf(`
	`487`	`+ "HTTP status %ld, response = \"%s\"", status, response_body->c_str());`
`487`	`488`	`return false;`
`488`	`489`	`}`
`489`	`490`