Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components without selectors will have a default one assigned #106

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Components without selectors will have a default one assigned #106

merged 2 commits into from
Apr 18, 2019

Conversation

duck-nukem
Copy link
Collaborator

@duck-nukem duck-nukem commented Apr 17, 2019 •
edited
Loading

Should fix #105

Draft PR to showcase the idea, code style and test is debatable

@duck-nukem duck-nukem self-assigned this Apr 17, 2019
@duck-nukem
Components can now only be wrapped in a container if they have a sele…
03ece7b 
…ctor

Reverted a broader fix for the same issue
@duck-nukem duck-nukem marked this pull request as ready for review April 17, 2019 13:14
@getsaf getsaf merged commit 04005f6 into getsaf:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getsaf getsaf getsaf approved these changes

Assignees

@duck-nukem duck-nukem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProxyShallowContainer creates <undefined ></undefined> without a selector in the Component
2 participants
@duck-nukem @getsaf