test(nx-heroku): add unit tests for webhooks and config vars tables parsers

Author: getlarge

packages/nx-heroku/src/executors/common/heroku/config-vars.spec.ts

@@ -0,0 +1,28 @@
+import { parseConfigVarsTable } from './config-vars';
+
+const configVarsTable = [
+  'CLUSTER_ENABLED:            true',
+  'DISK_STORAGE_TRESHOLD:      161061273600',
+  'EVENT_LOOP_DELAY_THRESHOLD: 100',
+  'HOSTNAME:                   0.0.0.0',
+  'LOG_CONCURRENCY:            true',
+  'MAX_PAYLOAD_SIZE:           1',
+  'MEMORY_RSS_TRESHOLD:',
+];
+
+const configVars = {
+  CLUSTER_ENABLED: 'true',
+  DISK_STORAGE_TRESHOLD: '161061273600',
+  EVENT_LOOP_DELAY_THRESHOLD: '100',
+  HOSTNAME: '0.0.0.0',
+  LOG_CONCURRENCY: 'true',
+  MAX_PAYLOAD_SIZE: '1',
+  MEMORY_RSS_TRESHOLD: '',
+};
+
+describe('ConfigVars', () => {
+  it('parseConfigVarsTable - should return a valid Variables object from a table', () => {
+    const result = parseConfigVarsTable(configVarsTable);
+    expect(result).toEqual(configVars);
+  });
+});

packages/nx-heroku/src/executors/common/heroku/config-vars.ts

@@ -46,10 +46,9 @@ export function serializeConfigVars(
   variables: Variables,
   quote: ConfigVarQuote = `'`
 ): SerializedConfigVar[] {
-  return Object.entries(variables).reduce((acc, [key, value]) => {
-    acc.push(serializeConfigVar(key, value, quote));
-    return acc;
-  }, []);
+  return Object.entries(variables).map(([key, value]) =>
+    serializeConfigVar(key, value, quote)
+  );
 }
 
 export async function setConfigVars(options: {

packages/nx-heroku/src/executors/common/heroku/webhooks.spec.ts

@@ -0,0 +1,49 @@
+import { parseWebhooksTable, Webhook } from './webhooks';
+
+const webhooksTable = [
+  '1965e28c-b99f-4c14-a64c-582efc7667ae https://webhook-handler.io/receive api:build,dyno sync',
+  '682df0e5-67f8-4a3b-a71d-78451470b997 https://webhook-handler.io/receive api:build,api:release,dyno sync',
+  '5541c980-0835-4063-bc70-9a11d5b8a016 https://webhook-handler.io/receive api:build,api:release,dyno notify',
+  'bffc659a-d802-4761-86d5-7f343c135eca https://webhook-handler.io/receive api:addon sync',
+  '9caf5cfb-ceac-4512-b197-fab47b3629f2 https://webhook-handler.io/receive api:formation sync',
+];
+
+const webhooks: Webhook[] = [
+  {
+    id: '1965e28c-b99f-4c14-a64c-582efc7667ae',
+    url: 'https://webhook-handler.io/receive',
+    include: 'api:build,dyno',
+    level: 'sync',
+  },
+  {
+    id: '682df0e5-67f8-4a3b-a71d-78451470b997',
+    url: 'https://webhook-handler.io/receive',
+    include: 'api:build,api:release,dyno',
+    level: 'sync',
+  },
+  {
+    id: '5541c980-0835-4063-bc70-9a11d5b8a016',
+    url: 'https://webhook-handler.io/receive',
+    include: 'api:build,api:release,dyno',
+    level: 'notify',
+  },
+  {
+    id: 'bffc659a-d802-4761-86d5-7f343c135eca',
+    url: 'https://webhook-handler.io/receive',
+    include: 'api:addon',
+    level: 'sync',
+  },
+  {
+    id: '9caf5cfb-ceac-4512-b197-fab47b3629f2',
+    url: 'https://webhook-handler.io/receive',
+    include: 'api:formation',
+    level: 'sync',
+  },
+];
+
+describe('Webhooks', () => {
+  it('parseWebhooksTable - should return a valid Webhook objects array from a table', () => {
+    const result = parseWebhooksTable(webhooksTable);
+    expect(result).toEqual(webhooks);
+  });
+});

packages/nx-heroku/src/executors/deploy/executor.spec.ts

@@ -131,6 +131,10 @@ describe('Deploy Executor', () => {
     expect(herokuDeployService.close).toBeCalled();
   });
 
+  // TODO: test
+  // validateOptions
+  // setEnvironmentVariables
+  // setupHeroku
   it('should instantiate the heroku app factory', async () => {
     options.config = ['development', 'production'];
     herokuDeployService['validateOptions'] = jest.fn();