refactor(wallet): Extract usage calculation into service #4682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context `Wallets::Balance::RefreshOngoingService` and `Wallets::Balance::RefreshOngoingUsageService` contained duplicated logic for computing customer usage amounts across subscriptions. ## Description This extracts usage calculation logic into `Customers::SubscriptionsUsageService` which computes fees and billed usage amount for all active subscriptions.
groyoh
force-pushed
the
chore/refactor-wallet-refresh
branch
from
b972f36 to
ffc79bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Wallets::Balance::RefreshOngoingServiceandWallets::Balance::RefreshOngoingUsageServicecontained duplicated logic for computing customer usage amounts across subscriptions.Description
This extracts usage calculation logic into
Customers::SubscriptionsUsageServicewhich computes fees and billed usage amount for all active subscriptions.