Add tests

Author: floganz

.junie/guidelines.md

@@ -101,9 +101,9 @@ def assign_wallet_per_fee(fees)
         fees.each do |fee|
           key = fee.id || fee.object_id
 
-          applicable_wallets = Wallets::FindApplicableOnFeesService.call!(
-            allocation_rules:, fee:, first_match: true
-          ).applicable_wallets
+          applicable_wallets = Wallets::FindApplicableOnFeesService
+            .call!(allocation_rules:, fee:)
+            .applicable_wallets
 
           fee_wallet[key] = applicable_wallets.presence
         end

app/services/wallets/balance/refresh_ongoing_service.rb

@@ -78,9 +78,9 @@ def assign_wallet_per_fee(fees)
         fees.each do |fee|
           key = fee.id || fee.object_id
 
-          applicable_wallets = Wallets::FindApplicableOnFeesService.call!(
-            allocation_rules:, fee:, first_match: true
-          ).applicable_wallets
+          applicable_wallets = Wallets::FindApplicableOnFeesService
+            .call!(allocation_rules:, fee:)
+            .applicable_wallets
 
           fee_wallet[key] = applicable_wallets.presence
         end

app/services/wallets/balance/refresh_ongoing_usage_service.rb

@@ -64,7 +64,7 @@ def add_all_unique(target_array, source_array)
     end
 
     def wallets
-      @wallets ||= customer.active_wallets_in_application_order
+      @wallets ||= customer.wallets.active.in_application_order
         .includes(wallet_targets: :billable_metric)
     end
 

app/services/wallets/build_allocation_rules_service.rb

@@ -2,10 +2,9 @@
 
 module Wallets
   class FindApplicableOnFeesService < BaseService
-    def initialize(allocation_rules:, fee:, first_match: false)
+    def initialize(allocation_rules:, fee:)
       @allocation_rules = allocation_rules
       @fee = fee
-      @first_match = first_match
       super
     end
 
@@ -26,10 +25,10 @@ def call
 
     private
 
-    attr_reader :allocation_rules, :fee, :first_match
+    attr_reader :allocation_rules, :fee
 
     def result_with(wallets)
-      result.applicable_wallets = first_match ? wallets.first : wallets
+      result.applicable_wallets = wallets.first
       result
     end
   end