Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CompiledFile.php #1693

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Update CompiledFile.php #1693

merged 1 commit into from
Nov 1, 2017

Conversation

vdakalov
Copy link
Contributor

@vdakalov vdakalov commented Oct 13, 2017

const CACHE_DIR already defined with trailing slash

define('CACHE_DIR', ROOT_DIR . 'cache/');

const CACHE_DIR already defined with trailing slash

```php
define('CACHE_DIR', ROOT_DIR . 'cache/');
```
@mahagr
Copy link
Member

mahagr commented Oct 16, 2017

Looks OK, though I would really want to get rid of those consts as they do not work in multisite if you want an individual cache location for each site. :)

@rhukster rhukster merged commit 2cd469c into getgrav:develop Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants