Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning to update command when new Grav version is available #1194

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Added warning to update command when new Grav version is available #1194

merged 1 commit into from
Dec 7, 2016

Conversation

Perlkonig
Copy link
Contributor

After coming up in the forum, I've added a warning to the gpm/update command if it notices that a new Grav version is available. My understanding is that best practice is to bin/selfupgrade before bin/update.

@rhukster
Copy link
Member

rhukster commented Dec 7, 2016

The only issue I have with this, is there is a minor chance that the dependencies are such that you shouldn't update Grav first. I can't believe this would really ever be the case, but it 'might', and your warning is kinda fatal if you decline.

maybe it should be a strong warning, but let you continue if you ignore?

@Perlkonig
Copy link
Contributor Author

It does let you continue if you want. It's up to you. You can answer "Y" to the question.

I could clarify "If you continue without also updating Grav, blah..." The real issue seems to be updating plugins that require the newer version of Grav, but the developer wasn't aware of that and didn't add a dependency. Also, since plugins update more frequently than Grav itself, people may be in a habit of updating plugins without even realizing that an updated version of Grav is available.

@rhukster
Copy link
Member

rhukster commented Dec 7, 2016

Ok, cool, i misread it then. Yeah, it's good practice to update Grav first, so the warning is good.

@rhukster rhukster merged commit 7b2716d into getgrav:develop Dec 7, 2016
@Perlkonig Perlkonig deleted the feature/gpm-new-version-warning branch December 7, 2016 21:20
@rhukster
Copy link
Member

rhukster commented Dec 7, 2016

BTW in future, please add a CHANGELOG.md entry too as part of the PR.. saves me doing it as a separate.

@Perlkonig
Copy link
Contributor Author

Will do that in the future. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants