Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 'system.errors.verbosity' to eventually replace 'system.errors.display' #1091

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Adding 'system.errors.verbosity' to eventually replace 'system.errors.display' #1091

merged 1 commit into from
Oct 12, 2016

Conversation

Perlkonig
Copy link
Contributor

  • Introduces three levels of verbosity:
    • 2: Full stack trace
    • 1: Current Grav error page
    • 0: Bare 500 response
  • Backwards compatible
    • If verbosity isn't set, then it looks at display.
    • Otherwise, verbosity is taken instead of display.
    • If accepted, I suggest marking display as deprecated for a release or two and documenting the change.
    • Adopting this approach will not break legacy installs. Not updating your config file results in zero change in Grav behaviour.

References Issue #1064 and closed PR #1089. Thanks!

@rhukster rhukster merged commit 4f8ac36 into getgrav:develop Oct 12, 2016
@rhukster
Copy link
Member

Thanks!

rhukster added a commit that referenced this pull request Oct 12, 2016
…for full backwards compatibility (even on save)
@rhukster
Copy link
Member

as you can see i tweaked your PR a little. basically i removed the new verbosity option and reused the existing display one. By also changing the values to 1, 0, -1 I was able to maintain backwards compatibility with the old true (1) and false (0) values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants