Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grav 1.6 update removes Google fonts from pipelined css #2440

Closed
MattAppleton opened this issue Apr 11, 2019 · 4 comments
Closed

Grav 1.6 update removes Google fonts from pipelined css #2440

MattAppleton opened this issue Apr 11, 2019 · 4 comments

Comments

@MattAppleton
Copy link
Contributor

MattAppleton commented Apr 11, 2019

Hello! Since updating to the new 1.6 Grav... I think this might be a reoccurrence of #1763

Previously I have been adding Google fonts to my css like this

@import url('https://fonts.googleapis.com/css?family=EB+Garamond:400,400i,500,500i,600,600i,700,700i,800,800i');

This @import is now omitted from the pipelined css since the update.
If I put a direct link into my base.html.twig like so

<link href="https://fonts.googleapis.com/css?family=EB+Garamond:400,400i" rel="stylesheet">

my fonts reappear...

@rhukster
Copy link
Member

Hmm.. seems this fix got missed in the Assets rewrite. I will take a look.

@MattAppleton
Copy link
Contributor Author

thanks... hadn't tested whether using local font files and @font-face { ...} works still, but either way it seems to be a bug.

@rhukster
Copy link
Member

local fonts definitely work as i'm using them extensively.

looking over the code, and the last 'fixes' maitas did to address this before are still there, so not sure why it's not working. I'l create a quick test setup

@rhukster
Copy link
Member

Ok was something else.. anyway fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants