Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract footer to separate partial twig #62

Closed
esocode opened this issue Oct 14, 2018 · 1 comment
Closed

Extract footer to separate partial twig #62

esocode opened this issue Oct 14, 2018 · 1 comment

Comments

@esocode
Copy link
Contributor

esocode commented Oct 14, 2018

Currently the site footer is contained in base.html.twig. That makes it difficult to modify the footer in themes that inherit from Quark because it would either require to copy and modify base.html.twig, thus decoupling it from future Quark updates, or to copy and modify page templates like default.html.twig which would require the replication of code in all pages.

This could be avoided if Quark imported it's default footer twig with {% include 'partials/footer.html.twig' %} which could then be overridden by inheriting themes.

@rhukster
Copy link
Member

Done for next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants