-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multilanguage: UI broken after saving page + file extension broken when saving page in second language: default.md.fr.md #2282
Comments
Perhaps this is caused by an outdated version of the Admin plugin. I'm running with v1.10.27 against Grav 1.7.33 and experiencing the same. @pamtbaau, what version of Admin are you experiencing this with? Also saving a content item into another language (e.g. English item being saved as French) caused superfluous suffix added to the markdown file resulting in |
I did my tests on a fresh install of the latest versions: Grav 1.7.33 + Admin 1.10.33.1. This is weird. Created another fresh install and saving the page in the first language return a correct UI and saving the page in second language gives an error because of a faulty file extension: default.md.fr.md I've update my initial post |
After some more tests, it seems to be a Grav core issue and not Admin.
Looking at the changelog of Grav core, the following sound suspicious:
|
@rhukster please help figure this out. |
I'm looking into this now. I am able to reproduce the issue, so I'm just trying to figure out what goes wrong. |
Clearing cache fixed the issue for me. Huh.. |
Phew, that was a hard issue to track down. It's fixed now in CI! |
(Was fixed in Grav) |
Great! Something I can do to test? |
Looks like we didn't have CI builds available, lol. OK, so here's the fix: getgrav/grav@6fa96ca#diff-c392650076318a0cca3f36706cc910159a2f35242ef8b7db4da2bcb61bad761dR141-R144 |
Cloned branch 'develop' and ran above steps. All seems to be working well! Thank you! |
Or that, lol. |
When saving a new page in a multi-lingual site, the Admin UI is broken.
Steps to reproduce:
Create a fresh install from zip with Grav 1.7.33. + Admin
Open Admin
Create new page and save: All is well
Add languages
en
andfr
in Configuration panelCreate new page and save: Faulty page layout
Save current page as second language: Page throws error
Inspect the filesystem: Faulty file extension
The text was updated successfully, but these errors were encountered: