fix: Migrate from better-sqlite3 to node-sqlite3-wasm #2246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the
better-sqlite3
library withnode-sqlite3-wasm
.Benefits:
Dependency updates:
packages/cli/package.json
: Removedbetter-sqlite3
and addednode-sqlite3-wasm
as a dependency. [1] [2]packages/search/package.json
: Removedbetter-sqlite3
and addednode-sqlite3-wasm
as a dependency.Code modifications:
node-sqlite3-wasm
instead ofbetter-sqlite3
in multiple files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]new sqlite3(indexFile)
tonew sqlite3.Database(indexFile)
in several functions. [1] [2] [3] [4] [5] [6]prepare
andrun
methods inFileIndex
andSnippetIndex
classes. [1] [2] [3] [4] [5] [6]These changes ensure compatibility with the new SQLite library and maintain the functionality of the existing codebase.