fix: do not return LNClient while shutting down #600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Sep 3, 2024
| @@ -17,7 +17,11 @@ func (svc *service) StopApp() { | |||
| } | |||
|
|
|||
| func (svc *service) stopLNClient() { | |||
| defer svc.wg.Done() | |||
| svc.isLNClientShuttingDown = true | |||
There was a problem hiding this comment.
maybe we can do
lnClient := svc.lnClient
svc.lnClient = nil
and proceed to shut down lnClient
bumi
reviewed
Sep 3, 2024
| @@ -234,6 +234,9 @@ func (svc *service) GetEventPublisher() events.EventPublisher { | |||
| } | |||
|
|
|||
| func (svc *service) GetLNClient() lnclient.LNClient { | |||
| if svc.isLNClientShuttingDown { | |||
There was a problem hiding this comment.
is this LNClient specific? or can it be a global boolean indicating the shutdown?
There was a problem hiding this comment.
I do not think we need one. See #605
|
Closing in favor of #605 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #391 - This issue is actually because migrate node is not working and is giving the user a 0-byte file, hence resulting in an EOF error while reading
Description
Sometimes during backup, calls to get the LNClient information are invoked (not exactly sure why, but it happens randomly), in between the LNClient stop process (see screenshot where calls to get node info and channels are requested between LDK shutdown initiation and complete) which causes the app to panic, this PR adds an
isLNClientShuttingDownvar so thatGetLNClientreturns nil without making calls to LDK during shutdown.