Skip to content

Commit 69f7576

Browse files
committed
clean up and default to tag as latest
1 parent 4212a7d commit 69f7576

File tree

3 files changed

+1
-80
lines changed

3 files changed

+1
-80
lines changed

.github/workflows/release_local_backend.yml

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,6 @@ name: Release Self-Hosted Backend
22

33
on:
44
workflow_call:
5-
inputs:
6-
tag_latest:
7-
description: "Tag image as latest"
8-
type: boolean
9-
required: true
105
outputs:
116
backend_x64_digest:
127
description: "x64 image digest"
@@ -85,32 +80,3 @@ jobs:
8580
matrix-step-name: build
8681
outputs:
8782
result: "${{ steps.read.outputs.result }}"
88-
89-
# push:
90-
# name: Push merged image manifest
91-
# needs: [read]
92-
# runs-on: ubuntu-latest
93-
# steps:
94-
# - name: Login to GitHub Container Registry
95-
# uses: docker/login-action@v2
96-
# with:
97-
# registry: ghcr.io
98-
# username: ${{ github.actor }}
99-
# password: ${{ secrets.GITHUB_TOKEN }}
100-
101-
# - name: Set up Docker Buildx
102-
# uses: docker/setup-buildx-action@v3
103-
104-
# - name: Push manifest
105-
# run: |
106-
# docker manifest create ghcr.io/get-convex/convex-backend:${{ github.sha }} \
107-
# --amend ghcr.io/get-convex/convex-backend@${{ fromJson(needs.read.outputs.result).digest['backend-x64'] }} \
108-
# --amend ghcr.io/get-convex/convex-backend@${{ fromJson(needs.read.outputs.result).digest['backend-arm64'] }}
109-
# docker manifest push ghcr.io/get-convex/convex-backend:${{ github.sha }}
110-
111-
# if [[ "${{ inputs.tag_latest }}" == "true" ]]; then
112-
# docker manifest create ghcr.io/get-convex/convex-backend:latest \
113-
# --amend ghcr.io/get-convex/convex-backend@${{ fromJson(needs.read.outputs.result).digest['backend-x64'] }} \
114-
# --amend ghcr.io/get-convex/convex-backend@${{ fromJson(needs.read.outputs.result).digest['backend-arm64'] }}
115-
# docker manifest push ghcr.io/get-convex/convex-backend:latest
116-
# fi

.github/workflows/release_local_dashboard.yml

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,6 @@ name: Release Self-Hosted Dashboard
22

33
on:
44
workflow_call:
5-
inputs:
6-
tag_latest:
7-
description: "Tag image as latest"
8-
type: boolean
9-
required: true
105
outputs:
116
dashboard_x64_digest:
127
description: "x64 image digest"
@@ -79,32 +74,3 @@ jobs:
7974
matrix-step-name: build
8075
outputs:
8176
result: "${{ steps.read.outputs.result }}"
82-
83-
# push:
84-
# name: Push merged image manifest
85-
# needs: [read]
86-
# runs-on: ubuntu-latest
87-
# steps:
88-
# - name: Login to GitHub Container Registry
89-
# uses: docker/login-action@v2
90-
# with:
91-
# registry: ghcr.io
92-
# username: ${{ github.actor }}
93-
# password: ${{ secrets.GITHUB_TOKEN }}
94-
95-
# - name: Set up Docker Buildx
96-
# uses: docker/setup-buildx-action@v3
97-
98-
# - name: Push manifest
99-
# run: |
100-
# docker manifest create ghcr.io/get-convex/convex-dashboard:${{ github.sha }} \
101-
# --amend ghcr.io/get-convex/convex-dashboard@${{ fromJson(needs.read.outputs.result).digest['dashboard-x64'] }} \
102-
# --amend ghcr.io/get-convex/convex-dashboard@${{ fromJson(needs.read.outputs.result).digest['dashboard-arm64'] }}
103-
# docker manifest push ghcr.io/get-convex/convex-dashboard:${{ github.sha }}
104-
105-
# if [[ "${{ inputs.tag_latest }}" == "true" ]]; then
106-
# docker manifest create ghcr.io/get-convex/convex-dashboard:latest \
107-
# --amend ghcr.io/get-convex/convex-dashboard@${{ fromJson(needs.read.outputs.result).digest['dashboard-x64'] }} \
108-
# --amend ghcr.io/get-convex/convex-dashboard@${{ fromJson(needs.read.outputs.result).digest['dashboard-arm64'] }}
109-
# docker manifest push ghcr.io/get-convex/convex-dashboard:latest
110-
# fi

.github/workflows/release_self_hosted_images.yml

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
tag_latest:
77
description: "Tag images as latest"
88
type: boolean
9-
default: false
9+
default: true
1010
required: true
1111
push:
1212
branches:
@@ -18,8 +18,6 @@ jobs:
1818
release_backend:
1919
uses: ./.github/workflows/release_local_backend.yml
2020
with:
21-
# Do not tag docker images triggered by migrations as latest.
22-
tag_latest: false
2321
permissions:
2422
contents: read
2523
packages: write
@@ -28,8 +26,6 @@ jobs:
2826
release_dashboard:
2927
uses: ./.github/workflows/release_local_dashboard.yml
3028
with:
31-
# Do not tag docker images yet
32-
tag_latest: false
3329
permissions:
3430
contents: read
3531
packages: write
@@ -48,13 +44,6 @@ jobs:
4844
if: success()
4945
runs-on: ubuntu-latest
5046
steps:
51-
- name: Debug outputs
52-
run: |
53-
echo "Backend outputs:"
54-
echo "${{ toJson(needs.release_backend.outputs) }}"
55-
echo "Dashboard outputs:"
56-
echo "${{ toJson(needs.release_dashboard.outputs) }}"
57-
5847
- name: Login to GitHub Container Registry
5948
uses: docker/login-action@v2
6049
with:

0 commit comments

Comments
 (0)