Fixed divide-by-zero errors in ecef2geodetic caused by changes in 3.0.0 release. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the change in commit dde1b9 to use isclose(), this now fails with the following exception when trying to convert multiple locations (len(z) > 1) and one or more of them has a divide-by-zero error: ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
If one or more values would divide by zero and needs to use a fallback Beta value, it's still necessary to calculate the correct Beta for any other values that would have succeeded. Previously, this used the same fallback value for all positions if even just one failed.
scivision
added a commit
that referenced
this pull request
Nov 20, 2023
|
@adamshapiro0 I had to revert this because it broke a lot of tests. I reimplemented it, and wonder if this works for your scenario or if it needs further improvement. |
scivision
added a commit
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the recent change to use
isclose()in commit dde1b9c,ecef2geodeticnow raisesValueErrorif you try to convert more than one position, and at least one of those results in a divide-by-zero error. This fixes that, and also fixes theBetavalue used for all positions that did not have a divide-by-zero error.