add serverType option to wms & csw catalog entries #8167

[landryb]

if undefined or set to "geoserver", the behaviour is unchanged. If set to "no-vendor", then TILED query parameter isnt sen't to the remote wms server, and the "tiled" and "localizedLayerStyles" options are hidden in the layer parameters.

more vendor options can be sent/avoided this way. Improves interoperability when displaying and printing layers coming from mapproxy.

closes #7809
closes #7877
closes #7879

Description

Please check if the PR fulfills these requirements

• The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

• Feature

Issue

What is the current behavior?

#7809, #7877 & #7879

What is the new behavior?
can display and print layers coming from mapproxy, once "no-vendor" is set for the catalog entry.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

• No

Other useful information

• [interoperability] add flag to source when we know it's provided by geoserver #8167 (comment) is .. strange.

• 4b09ed5 isnt included after discussion with @allyoucanmap - widget codepaths have to be revisited ?

[landryb]

i see the saveMapConfiguration tests are failing, i think i can fix that.

[allyoucanmap]

@landryb I just pushed a commit with the support fot serverType in dashboard so you need to update your local branch

[allyoucanmap]

@landryb I also included the fix mentioned here #8167 (comment)

[allyoucanmap]

@landryb if you could confirm that the pending problems has been solved by the new commits then I'm going to do a final review, thanks

[landryb]

i've pulled locally your last commits, and with 986ea75 the serverType selection works for csw catalogs in the map.

I've also added pre-configured no-vendor and geoserver entries to the services array of DashboardEditor plugin config, the value of serverType is properly propagated there, and adding layers from such catalogs shows the correct behaviour (eg TILED sent when serverType is GEOSERVER only), so 5000365 seems to be correct.

but the only thing that isn't working seem to be the serverType selection in a csw catalog in the dashboard editor.

it's as if 986ea75 didnt have any effect for the csw catalogs in the dashboard editor.

[landryb]

i think i understand what weird thing is happening.. the various actions are triggered, but the display isnt updated straight away. I need to make a selection in the tilesize or format entries to have the serverType display updated, and vice-versa.

the same strange behaviour (display being not updated with the just selected options) can be reproduced in the wms catalog entry of the dashboard editor.

and i cant replicated that strange behaviour with the regular csw/wms catalog entries in the map editor.

[allyoucanmap]

@landryb it seems an issue related to the service object not correctly updated, here the fix bdf7c90

[landryb]

@landryb it seems an issue related to the service object not correctly updated, here the fix bdf7c90

thanks, can confirm that with this commit, the broken behaviour in the csw & wms catalog entries advanced properties is fixed in the dashboard editor, changing serverType/tilesize is directly updated in the UI. LGTM!

[allyoucanmap]

@landryb merged, thanks for the contribution!

[allyoucanmap]

@ElenaGallo please test on dev and let us know if we can backport on branch 2023.01.xx

[ElenaGallo]

Hi @landryb @allyoucanmap

once added cadastre layer from https://tiles.craig.fr/pci/service and ortho layer from https://tiles.craig.fr/ortho/service with NO_VENDOR as Server Type, layers are visible but it is not possible to print them. The following error appears:

Error while generating PDF:
org.mapfish.print.InvalidJsonValueException: spec.layers[1].baseURL has an invalid value: https://tiles.craig.fr/ortho/service ? (Illegal character in scheme name at index 0: https://tiles.craig.fr/ortho/service ?)
at org.mapfish.print.map.readers.HTTPMapReader.(HTTPMapReader.java:74)
at org.mapfish.print.map.readers.TileableMapReader.(TileableMapReader.java:42)
at org.mapfish.print.map.readers.WMSMapReader.(WMSMapReader.java:98)
at org.mapfish.print.map.readers.WMSMapReader.(WMSMapReader.java:46)
at org.mapfish.print.map.readers.WMSMapReader$Factory.create(WMSMapReader.java:84)
at org.mapfish.print.map.readers.MapReaderFactoryFinder.create(MapReaderFactoryFinder.java:36)
at org.mapfish.print.map.MapChunkDrawer.renderImpl(MapChunkDrawer.java:120)
at org.mapfish.print.ChunkDrawer.render(ChunkDrawer.java:55)
at org.mapfish.print.config.layout.MapBlock$1.render(MapBlock.java:77)
at org.mapfish.print.PDFCustomBlocks.addAbsoluteDrawer(PDFCustomBlocks.java:187)
at org.mapfish.print.config.layout.MapBlock.render(MapBlock.java:73)
at org.mapfish.print.config.layout.Page.render(Page.java:80)
at org.mapfish.print.config.layout.Layout.render(Layout.java:64)
at org.mapfish.print.output.AbstractOutputFormat.doPrint(AbstractOutputFormat.java:31)

How to Reproduce

• Open this map
• Follow the steps in the video below:

print.mov

[landryb]

hi @ElenaGallo , the map link you gave requires login and i havent been able to login with either admin/admin or user/user. In your video i see the STR, but can't see what's the wrong request done by the print module.

i've tried reproducing your map (gzipped & attached below), adding two wms layers from mapproxy, and here it correctly generates a pdf preview.
test-print-mapproxy.json.gz

[landryb]

the POST done to http://localhost:8081/proxy/?url=http%3A%2F%2Flocalhost%3A8080%2Fmapstore%2Fpdf%2Fcreate.json had this attached payload
post.json.gz

[landryb]

wild guess from the error message, would there be an extra space between service and ? in the POST data sent in your map ?

[ElenaGallo]

@landryb sorry, now the map is public. In any case, now I can print and everything works as it should. Thanks

[ElenaGallo]

@allyoucanmap the rest passed on DEV, @landryb please backport to 2023.01.xx. Thanks