Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honour layers.featuresCrs also in Feature.jsx #1197

Merged
merged 1 commit into from
Oct 24, 2016

Conversation

manisandro
Copy link
Contributor

Followup for 3fad9fd

@simboss simboss added the ready label Oct 24, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 80.893% when pulling 409c3c4 on sourcepole:featurescrs into 3c17884 on geosolutions-it:master.

Copy link
Contributor

@mbarto mbarto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add getDefaultProps in Feature.jsx to have a default of 'EPSG:4326' for featureCrs. I know you already do that in the plugin, but Feature.jsx can be used in other contexts too, so a default should prevent crashes.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 80.894% when pulling 8cd7f1b on sourcepole:featurescrs into 3c17884 on geosolutions-it:master.

@mbarto mbarto merged commit 3bd3d23 into geosolutions-it:master Oct 24, 2016
@mbarto mbarto removed the ready label Oct 24, 2016
@manisandro manisandro deleted the featurescrs branch October 24, 2016 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants