Use geoana 0.2.1 for building the website #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to see if this solves an error in `ElectrostaticSphere` due to a change in the expected type of the `primary_field` argument.
santisoler
changed the title
requirements.txt
This reverts commit 9a5bfa3.
Just use the old pip for Python 3.9
The build process worked in the previous commit! So now let's try to make things clean.
It's nice to pin it there as well in case we are trying to create the environment locally.
santisoler
changed the title
requirements.txt
Merged
santisoler
added a commit
that referenced
this pull request
Dec 4, 2024
Use geoana==0.1.3 instead of 0.2.1. The latter had an issue with circular imports that made building the website to fail. This change (along with #579) should be also reverted when updating the repo to work with the latest version of geoana.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an older version of geoana to build the website to avoid errors coming from incompatibilities with the latest version. Install
geoana==0.2.1in GitHub Actions to run tests and to build the website. Just pinning it in therequirements.txtfile doesn't work because of missing build dependencies for that old version. So the build requirements (listed in a newrequirements-build-geoana.txtfile) are installed along with other needed packages (e.g. Sphinx), andgeoana=0.2.1gets installed withpipbut disabling the build isolation (passing--no-build-isolation).This fix is just a patch, we should make the repo compatible with latest geoana at some point. By then, we should revert these changes.