Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assignment of charge density for the right sphere #574

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Fix assignment of charge density for the right sphere #574

merged 3 commits into from
Dec 6, 2024

Conversation

thibaut-kobold
Copy link
Contributor

@thibaut-kobold thibaut-kobold commented Mar 23, 2023 •
edited by santisoler
Loading

Make use of sphere2 to compute the q2 charge density.

@thast thast mentioned this pull request Dec 6, 2024
Closed
@santisoler santisoler changed the title fix typo in electrostatic_sphere.rst Fix assignment of charge density for the right sphere Dec 6, 2024
@santisoler
Copy link
Member

Thanks @thibaut-kobold! I'll merge this.

Pinging @micmitch here, since he opened #583 to solve the same problem.

@santisoler santisoler merged commit 80f3c71 into geoscixyz:main Dec 6, 2024
2 checks passed
@micmitch
Copy link
Contributor

micmitch commented Dec 6, 2024

Nice. Good to get this fixed! Is there anything else that needs to be done to ensure that the update is reflected on the webpage?

https://em.geosci.xyz/content/maxwell2_static/fields_from_grounded_sources_dcr/electrostatic_sphere.html

@santisoler
Copy link
Member

Just wait for the CI gods to finish the deployment 😁:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santisoler santisoler santisoler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thibaut-kobold @santisoler @micmitch @thast