Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref/intro apps #528

Merged
merged 16 commits into from
Jul 18, 2018
Merged

Ref/intro apps #528

merged 16 commits into from
Jul 18, 2018

Conversation

lheagy
Copy link
Member

@lheagy lheagy commented Jul 17, 2018

First impressions

  • add the case history image to the index page
    image

Apps

  • more description on how to get up and running with Binder, Azure
    image

General cleanup

  • update copyright year to 2018
  • bibtex cleanup
  • add live links that are slow to resolve to the linkcheck ignore

@lheagy lheagy requested a review from sgkang July 17, 2018 03:29
@lheagy
Copy link
Member Author

lheagy commented Jul 17, 2018

before merging

  • coda patch
  • release notes

Copy link
Contributor

@sgkang sgkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lheagy looks great!

For binder, there is no problem, but for azure, we need to add pip install statement for each notebook, and may need some instructions about that.


.. image:: images/notebook_list.png

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way that we can automatically installing em_examples in azure? otherwise, we need to add
pip install em_examples statement in every notebook. Also, some guidance so that user can run jupyter notebooks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we need to set our python kernel consistently.
For different python, we need to re-install em_examples on azure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgkang: as long as users check the box that says clone recursively then all of the dependencies in requirements.txt are installed (including em_examples). so the pip install is not necessary at the top of the notebooks

@lheagy lheagy merged commit 4a9b6aa into master Jul 18, 2018
@lheagy lheagy deleted the ref/intro-apps branch July 18, 2018 01:54
@lheagy
Copy link
Member Author

lheagy commented Jul 18, 2018

Thanks @sgkang!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants