Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Abstract diagnostic code from Do_Fullchem #1421

Open
lizziel opened this issue Aug 30, 2022 · 2 comments
Open

[Feature Request] Abstract diagnostic code from Do_Fullchem #1421

lizziel opened this issue Aug 30, 2022 · 2 comments
Labels
category: Feature Request New feature or request never stale Never label this issue as stale no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Structural Modifications Related to GEOS-Chem structural modifications (as opposed to scientific updates)

Comments

@lizziel
Copy link
Contributor

lizziel commented Aug 30, 2022

There is a lot of diagnostic code within Do_Fullchem and it has been increasing lately for GEOS diagnostics. Some of it has previously been abstracted. It would be good to revisit this subroutine and abstract all the diagnostic code out to private subroutines within fullchem_mod.F90.
@lizziel lizziel changed the title Abstract diagnostic code from Do_Fullchem [Feature Request] Abstract diagnostic code from Do_Fullchem Oct 6, 2022
@lizziel lizziel transferred this issue from geoschem/GCST-internal Oct 6, 2022
@stale
Copy link

stale bot commented Nov 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the stale No recent activity on this issue label Nov 12, 2022
@yantosca yantosca added the category: Feature Request New feature or request label Nov 14, 2022
@stale stale bot removed the stale No recent activity on this issue label Nov 14, 2022
@yantosca yantosca added stale No recent activity on this issue topic: Structural Modifications Related to GEOS-Chem structural modifications (as opposed to scientific updates) no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations labels Nov 14, 2022
@stale stale bot removed the stale No recent activity on this issue label Nov 14, 2022
@lizziel lizziel added the never stale Never label this issue as stale label Nov 14, 2022
@yantosca
Copy link
Contributor

Also see #1953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: Feature Request New feature or request never stale Never label this issue as stale no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Structural Modifications Related to GEOS-Chem structural modifications (as opposed to scientific updates)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lizziel @yantosca