Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook to allow custom response objects #11

Open
cboulanger opened this issue Aug 31, 2020 · 2 comments
Open

Add hook to allow custom response objects #11

cboulanger opened this issue Aug 31, 2020 · 2 comments

Comments

@cboulanger
Copy link
Contributor

cboulanger commented Aug 31, 2020

Hi, I am still using the library and it works excellently. There is one reason why I am still using a fork, though, which is that I need a custom NotificationResponse (see the diff) and I wonder how best to go about in order to return to upstream. Since my use case is probably too special for integration, maybe the best solution is if you could add a hook that would allow to insert custom response objects into the batch at any time (not only as the result of an action).

Thank you for considering this enhancement.

@georgique
Copy link
Owner

@cboulanger I'd happy to implement this, but currently being pretty busy at other projects. If you manage to provide a pull request, I should be able to review it and accept, whereas working on this myself - just don't have time at the moment

@cboulanger
Copy link
Contributor Author

Do you have any preference as to how this should be implemented? I my current implementation, I use a static method of the controller to add to a list of NotificationResponses which will be added to the batch before the response is returned to the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants