You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I am still using the library and it works excellently. There is one reason why I am still using a fork, though, which is that I need a custom NotificationResponse (see the diff) and I wonder how best to go about in order to return to upstream. Since my use case is probably too special for integration, maybe the best solution is if you could add a hook that would allow to insert custom response objects into the batch at any time (not only as the result of an action).
Thank you for considering this enhancement.
The text was updated successfully, but these errors were encountered:
@cboulanger I'd happy to implement this, but currently being pretty busy at other projects. If you manage to provide a pull request, I should be able to review it and accept, whereas working on this myself - just don't have time at the moment
Do you have any preference as to how this should be implemented? I my current implementation, I use a static method of the controller to add to a list of NotificationResponses which will be added to the batch before the response is returned to the client.
Hi, I am still using the library and it works excellently. There is one reason why I am still using a fork, though, which is that I need a custom
NotificationResponse
(see the diff) and I wonder how best to go about in order to return to upstream. Since my use case is probably too special for integration, maybe the best solution is if you could add a hook that would allow to insert custom response objects into the batch at any time (not only as the result of an action).Thank you for considering this enhancement.
The text was updated successfully, but these errors were encountered: