Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build - Consider using frontend-maven-plugin ? #86

Open
pmauduit opened this issue Nov 18, 2019 · 2 comments
Open

Build - Consider using frontend-maven-plugin ? #86

pmauduit opened this issue Nov 18, 2019 · 2 comments
Labels
Blocked enhancement New feature or request New question Further information is requested

Comments

@pmauduit
Copy link
Member

In other geOrchestra webapps, where a build step which makes use of nodejs is involved, we do use the frontend-maven-plugin instead of having a seperate build phase outside of maven:

https://github.com/georchestra/georchestra/blob/19.04/console/pom.xml#L505-L535

The main advantage it could bring to the current situation is to have a simplified build, as the maven command could also take care of generating JS / static resources, simplifying e.g. CICD processes as well. From my PoV, it would have avoided having a webapp generated without the frontend resources (see my previous issue).

What is your opinion on it, do you think it could be a good addition to the project ?

@pmauduit pmauduit added enhancement New feature or request question Further information is requested labels Nov 18, 2019
@pmauduit pmauduit changed the title Build - Consider using maven-frontend-plugin ? Build - Consider using frontend-maven-plugin ? Nov 18, 2019
@mbarto
Copy link
Contributor

mbarto commented Nov 18, 2019

We used that initially, then we had some issues with npm 3 and decided to remove it: geosolutions-it/MapStore2@8173109#diff-eef89535a29b4a95a42d9de83cb53681

We can evaluate if we can bring it back with current nodejs / npm version

@pmauduit
Copy link
Member Author

Ok, thanks for the feedback

@tdipisa tdipisa closed this as completed Nov 18, 2019
@tdipisa tdipisa reopened this Nov 18, 2019
@tdipisa tdipisa added the New label May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked enhancement New feature or request New question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants