capture dct:spatial as bbox, if it contains a box

[pvgenuchten]

in some cases, bbox is strored in dct:spatial, nice to have it as bbox

added some csw parse tests, seemed not existing

[coveralls]

coverage: 60.296% (+1.3%) from 58.984%
when pulling e81b2e5 on pvgenuchten:if_dct_spatial_has_a_box
into 1354d06 on geopython:master.

[geographika]

@pvgenuchten - great to get some tests for the CSW parsing. It looks like there is a lot of shared code in the __init__ for CswRecord and Csw30Record that could be refactored into one function - maybe for another pull request.

A couple of questions:

1. If a document has both ows:BoundingBox and dct:spatial then self.bbox will overwrite the value from ows:BoundingBox with dct:spatial. Is this scenario possible, and if yes then should this be the correct precedence?
2. If dct:spatial is not a bbox in the form -180,-90,180,90 then self.spatial is set to val. What could val be - a string? It would be good to have an example document and test for this.

[geographika]

@pvgenuchten - we're looking to make a new release of OWSLib. If you have any thoughts on the above questions, please add to this ticket. Are you then happy to merge?

[pvgenuchten]

@pvgenuchten - great to get some tests for the CSW parsing. It looks like there is a lot of shared code in the __init__ for CswRecord and Csw30Record that could be refactored into one function - maybe for another pull request.

I'm not sure i'm able to manage the refactore, but for sure is a good idea. I'd say postpone to next PR.

1. If a document has both ows:BoundingBox and dct:spatial then self.bbox will overwrite the value from ows:BoundingBox with dct:spatial. Is this scenario possible, and if yes then should this be the correct precedence?

valid question, I will have a look, maybe we can store both?

2. If dct:spatial is not a bbox in the form -180,-90,180,90 then self.spatial is set to val. What could val be - a string? It would be good to have an example document and test for this.

dct:spatial indeed is often populated with a spatial label, such as London, Bretagne. Indeed good to add a test for it. A recommendation from geodcat-ap is at https://interoperable-europe.ec.europa.eu/release/how-should-dctspatial-and-dctlocation-be-used

[github-actions]

This Pull Request has been inactive for 90 days. In order to manage maintenance burden, it will be automatically closed in 7 days.

[github-actions]

This Pull Request has been inactive for 90 days. In order to manage maintenance burden, it will be automatically closed in 7 days.

[github-actions]

This Pull Request has been closed due to there being no activity for more than 90 days.

[tomkralidis]

assert isinstance(CswRecord, md)

[tomkralidis]

Can we use open() instead of io.open?

[tomkralidis]

Suggest the below (also for owslib/catalogue/csw3.py):

        val = record.find(util.nspath_eval('dct:spatial', namespaces))
        self.spatial = None
        if val is not None:
            val = util.testXMLValue(val)
            tokens = val.split(',')
            if len(tokens) == 4:
                self.bbox = ows.BoundingBox(None, namespaces['ows'])
                self.bbox.minx = tokens[0]
                self.bbox.miny = tokens[1]
                self.bbox.maxx = tokens[2]
                self.bbox.maxy = tokens[3]
            else:
                self.spatial = val